SharpHoundCommon icon indicating copy to clipboard operation
SharpHoundCommon copied to clipboard
verified publisher icon BloodHoundAD

Add WriteAltSecurityIdentities and WritePublicInformation

Open JonasBK opened this issue 4 months ago • 1 comments

Description

Collection of two new ACL permissions:

  • WriteAltSecurityIdentities
  • WritePublicInformation

Motivation and Context

Tickets: BED-6155

How Has This Been Tested?

Locally in lab environment.

Types of changes

  • [ ] Chore (a change that does not modify the application functionality)
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [x] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [x] Documentation updates are needed, and have been made accordingly.
  • [x] I have added and/or updated tests to cover my changes.
  • [x] All new and existing tests passed.
  • [ ] My changes include a database migration.

Summary by CodeRabbit

  • New Features
    • Expanded support for processing additional access rights related to user and computer objects, including new permissions for alternative security identities and public information.
  • Tests
    • Added new unit tests to verify handling of these specific access rights for user and computer scenarios.

JonasBK avatar Aug 04 '25 10:08 JonasBK

Walkthrough

Two new ACE types, WriteAltSecurityIdentities and WritePublicInformation, are introduced as constants in both the EdgeNames and ACEGuids classes. ACL processing logic is updated to recognize and yield these ACEs for User and Computer object types. Corresponding unit tests are added to verify the new behavior.

Changes

Cohort / File(s) Change Summary
ACE Type Constants
src/CommonLib/Enums/EdgeNames.cs, src/CommonLib/Processors/ACEGuids.cs		 Added new constant string fields for WriteAltSecurityIdentities and WritePublicInformation to both the EdgeNames and ACEGuids classes. These constants represent new ACE types and their associated GUIDs.
ACL Processing Logic
src/CommonLib/Processors/ACLProcessor.cs		 Updated ACL processing to handle and yield ACEs with WriteAltSecurityIdentities and WritePublicInformation rights for User and Computer object types. Refactored CertTemplate handling for clarity. No changes to exported or public entity declarations.
Unit Tests
test/unit/ACLProcessorTest.cs		 Added four new unit tests to verify ACL processing for the new ACE types and principal types (User and Computer). Reformatted class and method declarations for code style consistency. No changes to logic of existing tests.

Sequence Diagram(s)

sequenceDiagram
    participant Test as Unit Test
    participant ACLProcessor as ACLProcessor
    participant ACEGuids as ACEGuids
    participant EdgeNames as EdgeNames

    Test->>ACLProcessor: Call ProcessACL with ACE (WriteAltSecurityIdentities/PublicInformation)
    ACLProcessor->>ACEGuids: Lookup ACE GUID
    ACLProcessor->>EdgeNames: Lookup ACE name
    ACLProcessor-->>Test: Yield processed ACE (User/Computer, WriteAltSecurityIdentities/WritePublicInformation)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • definitelynotagoblin
  • MikeX777

Poem

Two new ACEs hop into code,
For users and computers, their rights bestowed.
Tests now check with eager delight,
That all is well with each new write.
A bunny cheers, with paws in the air—
Security’s handled with extra care! 🐇✨

[!NOTE]

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ade0a71f10a1d0434944e73f0527e3f1055f7565 and 4bfb80a467a0541b1bbd35e7dcd100e6fbfe35c3.

📒 Files selected for processing (4)
  • src/CommonLib/Enums/EdgeNames.cs (1 hunks)
  • src/CommonLib/Processors/ACEGuids.cs (1 hunks)
  • src/CommonLib/Processors/ACLProcessor.cs (1 hunks)
  • test/unit/ACLProcessorTest.cs (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • src/CommonLib/Enums/EdgeNames.cs
  • src/CommonLib/Processors/ACEGuids.cs
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/CommonLib/Processors/ACLProcessor.cs
  • test/unit/ACLProcessorTest.cs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
✨ Finishing Touches
  • [ ] 📝 Generate Docstrings
🧪 Generate unit tests
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch esc14

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Aug 04 '25 10:08 coderabbitai[bot]