SharpHoundCommon and SharpHoundRPC Version Mismatch in Sharphound.csproj

[shogunlab]

Hey there. I noticed that in previous SharpHoundCommon version bump commits such as https://github.com/BloodHoundAD/SharpHound/commit/0dff51835a1879e3b31f8494acd76dd72ac92fe6 and https://github.com/BloodHoundAD/SharpHound/commit/a18a9829c4c9e382a027cb8f1abf994e860199c5, both SharpHoundCommon and SharpHoundRPC package references receive a version bump in the Sharphound.csproj file. But, in the commit https://github.com/BloodHoundAD/SharpHound/commit/64ef0e56661734566b8bd0fc58d59c44c645c7fa, only SharpHoundCommon is updated to 4.0.9 while SharpHoundRPC remains on 4.0.8.

Was this intentional? If not, would it make sense to bump the SharpHoundRPC version in the package reference as well? If it was intentional, please feel free to close this issue and disregard. Thank you!

[rvazarkar]

Its not intentional, but it's also not going to affect anything. The RPC library hasn't received any updates in a significant period of time. At some point, I'll look into making the RPC library a pinned version along with the CommonLib. I'll make sure to update it in an upcoming MR, or if you'd like to make an MR for it, feel free and I'll accept it :)

[shogunlab]

Sounds good! Thank you for clarifying. Then yeah, I'll submit a pull request with an update to have the SharpHoundRPC version bumped to 4.0.9 in the 2.X branch.