SharpHound icon indicating copy to clipboard operation
SharpHound copied to clipboard

performance regression in 2.5.x

Open kokanin opened this issue 1 year ago • 1 comments

2.4.1 pulls 150 objects/second, 2.5.x pulls around 1.5, causing my patience to expire before collection finishes

kokanin avatar Aug 08 '24 13:08 kokanin

@kokanin - we pulled SharpHound v2.5.4 from BloodHound v5.13.0 for these concerns. We're working on a fix and expect to have a new v2.5.X version available here shortly!

StephenHinck avatar Aug 08 '24 15:08 StephenHinck

https://github.com/BloodHoundAD/SharpHound/releases/tag/v2.5.6

We published v2.5.6, give it a try and see if it works for you

rvazarkar avatar Sep 04 '24 15:09 rvazarkar

2.5.6 hovers around 2.5-2.7 objects/second

kokanin avatar Sep 06 '24 09:09 kokanin

What collection methods are you using? We've tested this in several different environments now and have not seen performance like that anywhere

rvazarkar avatar Sep 10 '24 18:09 rvazarkar

At least the ACL collection slows things to a crawl: Group -> starts around 40 obj/s, ends up at 250 obj/s Localgroup -> 30 obj/s LocalAdmin -> 30 obj/s Session -> 30 obj/s ACL -> 3 obj/s

kokanin avatar Sep 11 '24 07:09 kokanin

Would it be possible to run with -v 0 and get us the logs or is this sensitive data?

rvazarkar avatar Sep 16 '24 17:09 rvazarkar

I believe we identified the source of this slowdown and fixed it in https://github.com/BloodHoundAD/SharpHound/releases/tag/v2.5.7

rvazarkar avatar Sep 18 '24 15:09 rvazarkar

ACL collection going at 500 obj/s using 2.5.7 so it seems you fixed that part, thanks! It is still floating around 30 obj/s when doing -c All but I can live with this.

kokanin avatar Sep 30 '24 09:09 kokanin