David Keller

Results 57 comments of David Keller

I proposed `read_greedy` to be consistent with `read_fully` (which has nearly the same functionality and code). Also, the term "greedy" should be familiar to most developers already since it's also...

~~Implemented in #13574 (which I will work on soon.. probably)~~

Ah, seems like I misremembered what I did in that PR.. Yes, it only implements IO-to-IO decode

I think the `create_widget_func` returns the crystal wrapper to gtk and not the widget Also I think gtk wants a full transfer ```diff - ::Box(Proc(GObject::Object, Gtk::Widget)).unbox(lib_user_data).call(item) + tmp = ::Box(Proc(GObject::Object,...

I recently found out that the kernel args can easily be modified using `abroot kargs edit`. Removing the `lsm=integrity` parameter from the kernel args fixes the issue.

It would also be cool to have a way to canonicalize projects if a `.crystaldoc.yml` were added. For example, I mostly host my projects on GitLab and often create GitHub...

> @BlobCodes , I remember you wanted this feature years ago, and it was only possible due to your work on toggle refs. If you have time, at your own...

Dirty memory can always cause hard-to-fix bugs, so having clean memory be the default could be a gold idea. The main reason is to be able to provide a consistent...

> So just to clarify, this replaces #14604 and supplements #13574 which covers the decoding part. Right? Yes, although it is completely independent of #13574

As a note to anyone reviewing this: In the bulk encoding part (-> `#encode_base64_full_pairs_internal`), `memcpy` is used to copy the actual data triples over to the variable: https://github.com/crystal-lang/crystal/blob/b662f346c90c4d54d78317d249f48e12d7fcec32/src/base64.cr#L297 This was...