s2protocol icon indicating copy to clipboard operation
s2protocol copied to clipboard

--attributeevents missing scopes section on resume from replay, replays

Open breath20 opened this issue 8 years ago • 3 comments
trafficstars

I have noticed that on replays that are resumed from replay that the scopes section that is returned from the --attributevents is missing.

Here is an example replay http://sc2replaystats.com/download/4442170

Here is a piece of the section that is missing from the above replay (sample is from another replay) the section i'm talking about is this "scopes":{"16":{"4000":[{"attrid":4000,"namespace":999,"value":"Norm"}],"3009":[{"attrid":3009,"namespace":999,"value":"Amm"}],"3......

Let me know if you need any more info.

breath20 avatar Feb 27 '17 14:02 breath20

When resuming from a replay is that new replay savable? The attribute events I assume are being output as a result of the lobby code. These events are maybe not being played in this case. How important is this use-case to you?

jrepp avatar Mar 01 '17 16:03 jrepp

Yes resuming from replay does create a new replay file.

Out of 110k replays uploaded this season, only ~1,800 are affected by it, so its not a huge use case for me. I would call this a "nice to have" bug fix.

It most likely is more prominent in tournament replays than it would be in ladder games which is mostly what I get.

amartin916 avatar Mar 01 '17 16:03 amartin916

This is probably a code change to the client itself and how it handles rejoin events. I'll leave this open but consider lower priority than some of the other issues that are open.

jrepp avatar Mar 01 '17 17:03 jrepp