s2protocol icon indicating copy to clipboard operation
s2protocol copied to clipboard

Python 3.12: remove imp dependency

Open vschmidt91 opened this issue 1 year ago • 3 comments

s2protocol uses the imp module which was removed in Python 3.12: https://docs.python.org/3/library/imp.html

Any chance we can do without it?

vschmidt91 avatar Dec 16 '24 13:12 vschmidt91

Hi vschmidt91, thanks raising this issue. That would require either raising that with Blizzard and hoping, Alternatively, we would need to create our own version of that protocol.

Is it realistic to not use the latest version of Python?

Edit: Are you interested in contributing? I want to build a team. The next task is to find more contributors or, preferable, partners and to map out what needs to be done.

tchaecker avatar Dec 19 '24 21:12 tchaecker

Thanks for the assessment, I was just curious. This issue can probably be closed.

Background: burny-sc2 got updated to 3.12 recently and I'm using replay parsing for some ML predictors. But training can easily be decoupled from the bot itself, which seems like the way to go.

vschmidt91 avatar Dec 19 '24 21:12 vschmidt91

There's PR with this already #126 (and it was there for quite a long time). However it's not going to be merged, or at least, it's hard to expect it, given that they (Blizzard) struggle with updating/maintaining the game, let alone developer tools like this one.

But it's a simple patch, you can just apply and be done.

Talv avatar Dec 20 '24 20:12 Talv