s2protocol icon indicating copy to clipboard operation
s2protocol copied to clipboard

Published 20 hours ago • verified publisher icon Blizzard

Migrate _import_protocol to importlib

Open al-025 opened this issue 1 year ago • 1 comments
trafficstars

The current implementation of _import_protocol uses the deprecated imp library which was removed in Python 3.12. This PR reimplements _import_protocol with the superseding importlib library to allow compatibility with newer versions of Python.

al-025 avatar Feb 13 '24 02:02 al-025

This is a good change, users of Python 2 can rely on the older releases. I haven't worked at Blizzard for over 4 years so I can't push this PR forward.

I think a PR that would help this move forward would be to refactor travis to github actions. This would allow the tox job to run in the context of this PR and provide an easier path to merging. I would be surprised if the travis-ci stuff was still active.

jrepp avatar Feb 13 '24 19:02 jrepp