s2client-proto icon indicating copy to clipboard operation
s2client-proto copied to clipboard

Add a proto equivalent to sc2_typeenums.h

Open Databean opened this issue 7 years ago • 2 comments

https://github.com/Blizzard/s2client-api/blob/master/include/sc2api/sc2_typeenums.h

As sc2_typeeenums.h says, "All units and abilities are represented as unsigned numbers in the StarCraft II engine. This can make issue abilities unnecessarily hard."

This fact is also true with the proto API. As it is, any equivalent implementation of the sc2api client in another language will have to define its own equivalent of these enums, or force its users to figure out the unit indexes themselves.

Is it possible to define this as a protobuf enum as part of the protocol sent by the game?

Databean avatar Aug 11 '17 16:08 Databean

We definitely agree with you and have added this as something we will implement. We're not sure what the timeline will be on it though.

Thanks for bringing this up.

AnthonyBrunasso avatar Aug 11 '17 16:08 AnthonyBrunasso

Any update on this?

carlos-sarmiento avatar Jun 25 '18 08:06 carlos-sarmiento