node-rdkafka icon indicating copy to clipboard operation
node-rdkafka copied to clipboard

Published 20 hours ago • verified publisher icon Blizzard

add github action

Open yunnysunny opened this issue 2 years ago • 4 comments

Since the trvais ci is not free now, and the test on travis is all been skiped. I rewrite the CI use github action.

It 's import to merge this request , since the tests is not tirggered when new code was merge to master.

yunnysunny avatar Mar 27 '22 13:03 yunnysunny

Node.js 8 seems to fail…. https://github.com/yunnysunny/node-rdkafka/actions

cclauss avatar Jul 02 '22 11:07 cclauss

Node.js 8 seems to fail…. https://github.com/yunnysunny/node-rdkafka/actions

Need to update node-gyp to a correct version on Node 8. I will try the 6.x version.

yunnysunny avatar Jul 02 '22 11:07 yunnysunny

Awesome!! Extra credit? Node.js 18 on Windows 22

cclauss avatar Jul 02 '22 13:07 cclauss

Awesome!! Extra credit? Node.js 18 on Windows 22

Node-gyp does not work on Windows 2022, https://github.com/yunnysunny/node-rdkafka/runs/7162913449?check_suite_focus=true . When I run update command on Windows 2022, it failed https://github.com/yunnysunny/node-rdkafka/runs/7162957526?check_suite_focus=true

We can consider merging the request of https://github.com/nodejs/node-gyp/pull/2684 to see the error detail of executing powershell script. @cclauss

yunnysunny avatar Jul 03 '22 02:07 yunnysunny

This was partly done in #978 and I added Windows & Mac to the matrix in #998. I think this can be closed now?

GaryWilber avatar Jan 21 '23 00:01 GaryWilber