node-rdkafka icon indicating copy to clipboard operation
node-rdkafka copied to clipboard

Message timestamp not included in delivery report

Open sfescape opened this issue 7 years ago • 3 comments

Environment Information

  • OS [e.g. Mac, Arch, Windows 10]: Mac
  • Node Version [e.g. 8.2.1]: 8.9.4
  • NPM Version [e.g. 5.4.2]: 5.6
  • C++ Toolchain [e.g. Visual Studio, llvm, g++]:
  • node-rdkafka version [e.g. 2.3.3]: 2.3.3

Steps to Reproduce

Produce a message and include a dr_cb function. The report does not include the produced message timestamp.

node-rdkafka Configuration Settings ... 'request.required.acks': 1, 'dr_cb': function(err, data) { if( data.value ) { data.value = data.value.toString('utf8') } delivery_report.onNext(data) }

Additional context

The timestamp is available to consumers, it's just not in the delivery report.

sfescape avatar Jun 11 '18 20:06 sfescape

I don't think it's been implemented yet, so I'll classify this as a feature and try to get it into the next release.

Thanks for the report.

webmakersteve avatar Jun 17 '18 02:06 webmakersteve

Added it here: d8ddd8e4d3fabf94b123261b41fbf8ebc126e86d

webmakersteve avatar Jun 17 '18 03:06 webmakersteve

Looks good to me!

Thanks!

sfescape avatar Jun 17 '18 04:06 sfescape