dwarfcorp icon indicating copy to clipboard operation
dwarfcorp copied to clipboard

Performance : Soak tests

Open com1clyf3 opened this issue 6 years ago • 11 comments

https://steamcommunity.com/profiles/76561198021950261/recommended/252390/

Freezing and stuttering: The game itself runs fine at first. But after a few hours the game starts freezing and stuttering so bad it becomes unplayable. I'm not sure what triggers it, tho I assume it's a memory leak on enteties.

Save game corruption: After 5 hours on my first map, my save-times suddenly skyrocketed from 5 seconds to 5 minutes. Loadtimes also rose exponentially up to the point where all versions of my saves where suddenly corrupt. (Game froze when it had to load entities).

Reported May 4th, so might be gone. Doubt it. One of us should run a soak test.

com1clyf3 avatar May 31 '18 19:05 com1clyf3

Would be interesting to get save files from this person. Seems you've encountered something similar in #651. I don't understand the save/load times increasing, as it's something I've never experienced before and I'm not even sure what would cause it other than something creating a huge number of entities that don't get cleaned up or something. Obviously it's a bit tedious to test the game for 5 hours at a time, so I'm wondering if there are ways we can reproduce these issues in an automated way.

mklingen avatar Jun 01 '18 19:06 mklingen

Sent Naggert a message requesting a save. We'll see if we get anything.

com1clyf3 avatar Jun 01 '18 20:06 com1clyf3

I am experiencing this issue as well, I can upload my save if you like. It happens every time I play for many hours (not sure exactly when it starts happening) I will say there are a fair amount of orphaned objects in my world my dwarfs will not pick up which may be a contributing factor. Dwarfclaimed Hills_633_131724368089112869.zip

merticois avatar Jun 02 '18 19:06 merticois

FYI, we just ran a few "soak tests" and have plugged a few memory leaks that might be contributing to this issue. Still investigating.

mklingen avatar Jun 02 '18 20:06 mklingen

Would be interested to hear from more players after our last release. I'm hoping there should have been a significant improvement.

mklingen avatar Jun 05 '18 14:06 mklingen

I haven't been able to log any serious hours in yet but so far everything seems much smoother better. The only complaint I have is that the task selection highlights (specifically mining designated blocks) do not render outside of their layer. This makes it hard to plan multiple layers out because you have not context for what is above/below you. This should probably be a new issue but it would be nice to be able to see selected blocks/items a layer above and below your current layer.

merticois avatar Jun 05 '18 16:06 merticois

I also want to mention that the speed at which the issue would show up was directly proportional to the frequency of the autosaves. It got worse more often autosaves occurred, at least on my system. I slowed autosaves down to every 30 mins and got several days of 2-5 hour play sessions before I noticed an issue rather than one 2-5 hour play session at the default autosave interval.

merticois avatar Jun 05 '18 16:06 merticois

I haven't been able to log any serious hours in yet but so far everything seems much smoother better. The only complaint I have is that the task selection highlights (specifically mining designated blocks) do not render outside of their layer. This makes it hard to plan multiple layers out because you have not context for what is above/below you. This should probably be a new issue but it would be nice to be able to see selected blocks/items a layer above and below your current layer.

Unfortunately we had to make this change for performance reasons, though I can see if there's a middle ground.

mklingen avatar Jun 05 '18 16:06 mklingen

I also want to mention that the speed at which the issue would show up was directly proportional to the frequency of the autosaves. It got worse more often autosaves occurred, at least on my system. I slowed autosaves down to every 30 mins and got several days of 2-5 hour play sessions before I noticed an issue rather than one 2-5 hour play session at the default autosave interval.

That's an interesting point. I think our next soak tests should focus on autosave.

mklingen avatar Jun 05 '18 16:06 mklingen

I've made a request for soak saves from the players on Discord. We'll see what we get.

com1clyf3 avatar Jun 05 '18 17:06 com1clyf3

Regressing. Always good to run one or two a week to keep track.

com1clyf3 avatar Jul 26 '18 16:07 com1clyf3