blaze-persistence icon indicating copy to clipboard operation
blaze-persistence copied to clipboard
verified publisher icon Blazebit

Avoid generation of duplicated GROUP BY clauses

Open Mobe91 opened this issue 11 years ago • 3 comments

We sometimes generate clauses twice when we say e.g. groupByManager.applyGroupBys() orderByManager.buildGroupByClauses()

buildGroupByClauses() might generate clauses that have already been generated in applyGroupBys(). Such duplicates should be eliminated.

Mobe91 avatar Oct 13 '14 11:10 Mobe91

I think this is fixed. Seems like you put all clauses into a set and then render that.

beikov avatar Dec 17 '14 11:12 beikov

I just looked at the code again and if I understand your concern, it seems that this issue is fixed. Please confirm so that we can fix and close this issue.

beikov avatar Mar 12 '15 21:03 beikov

I just looked at the code an we are still using independent sets in OderByManager and GroupByManager so this issue should still be present.

Mobe91 avatar Mar 13 '15 08:03 Mobe91