#2010 unknown ids on window subquery
Description
Fix issue where join on window query and sort by left joined column breaks
Related Issue
Fixes https://github.com/Blazebit/blaze-persistence/issues/2010
Motivation and Context
See issue above for info
All the tests failed, with a cache error?
Thanks for notifying me about this. I updated the GitHub action step versions and rebased your PR.
Thank you, I've looked through the now failing tests, most of these seem to be due to the join on subquery not supported on hibernate pre-5.1, or unsupported in datanucleus/eclipselink. I've disabled the new test on those. The failures on the oracle DB seem to be related to #295 just as all the CTE tests are disabled for oracle, so I've also disabled testing on that.
Looks good to me, can you please squash the commits and use [#2010] unknown ids on window subquery as commit message?
Squashed and pushed, but isn't that usually done during merge?
Squashed and pushed, but isn't that usually done during merge?
Thanks. It can be done during merge, but then I think that authorship attribution might be messed up. Either way, having the PR follow our standards is the preferred approach.