ganon
ganon copied to clipboard
Insufficient and unequal methods for common 3-d objects
There are currently some methods called SurfaceAreaOf..
or VolumeOf..
that may live in /lib/*.js
.
They are incomplete and needs to be fixed!
Acceptance Criteria:
- Running
yarn test <methodName>
results in tests passing. - You have written a skeleton method for someone else to work on.
- You have written tests surrounding your skeleton method.
- Running
yarn lint
does not print any errors to the console! - Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.
Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.
Thank you so much for your contribution!
Hi @BlakeGuilloud I would like to work on this issue so that we can close #775 #773 and #766 and complete collection of such methods for common 3D objects in the Ganon library
Thanks @BlakeGuilloud I will try to complete the methods as soon as possible.