ganon icon indicating copy to clipboard operation
ganon copied to clipboard

Fix promisify function

Open kylevv opened this issue 7 years ago • 4 comments

There is currently a method called promisify that lives in /lib/promisify.js. It is incomplete and needs to be fixed!

Promisify takes an asynchronous function that uses node style callbacks and returns a function that will return a promise instead.

Acceptance Criteria:

  1. Running yarn test promisify results in tests passing.
  2. You have written a skeleton method for someone else to work on.
  3. You have written tests surrounding your skeleton method.
  4. Running yarn lint does not print any errors to the console!
  5. Optional: write one or two more tests surrounding the method you are solving to account for potential edge cases.

Please include the skeleton of a new method + an accompanying test for someone else to work on at the time of creating a pull request! A pull request will most likely be denied if it does not contain a skeleton method for someone else to work on! For more information, please read the Contributing Guide.

Thank you so much for your contribution!

kylevv avatar Oct 31 '17 04:10 kylevv

Requires #717 to be merged first.

kylevv avatar Oct 31 '17 04:10 kylevv

Can't believe no one has taken this yet!

BlakeGuilloud avatar Nov 01 '17 23:11 BlakeGuilloud

I can take a stab at it.

arturoromeroslc avatar Jan 04 '18 07:01 arturoromeroslc

@arturoromeroslc Have fun!

ktilcu avatar Jan 04 '18 16:01 ktilcu