ganon icon indicating copy to clipboard operation
ganon copied to clipboard

Published 20 hours ago • verified publisher icon BlakeGuilloud

Improve Existing Methods

Open BlakeGuilloud opened this issue 7 years ago • 5 comments

There are plenty of methods that could be improved upon, more clearly documented, or contain a better suite of tests surrounding them. Please feel free to jump in and help clean up some existing methods where you see fit!

Two great examples of well documented methods with great tests surrounding them are permute.js and combinations.js. Shoutout to @andreasgruenh for the work he did surrounding these features.

The same rule applies for improving methods in that when you create a pull request, if you can, please be sure to accompany it with a skeleton method for someone else to work on!!

BlakeGuilloud avatar Oct 17 '17 22:10 BlakeGuilloud

I can work on this

luisvillalba avatar Oct 18 '17 15:10 luisvillalba

Refactored #55 in #164

cjhaviland avatar Oct 19 '17 19:10 cjhaviland

@cjhaviland I made some minor requests in your pr #164 - Thanks for your work!!

BlakeGuilloud avatar Oct 19 '17 21:10 BlakeGuilloud

Is this issue closed?

newbazz avatar Oct 28 '17 15:10 newbazz

Hey @newbazz ! This issue will never be closed as there is always room for improvement. Feel free to browse through some of the methods and if you feel like you can improve anything, do it! Thanks!!

BlakeGuilloud avatar Oct 28 '17 15:10 BlakeGuilloud