ganon icon indicating copy to clipboard operation
ganon copied to clipboard

Feedback

Open BlakeGuilloud opened this issue 8 years ago • 19 comments

For anyone who thinks of ideas to improve what I am trying to accomplish here, or just has a comment about it! I hope the README was clear enough!

BlakeGuilloud avatar Oct 16 '17 22:10 BlakeGuilloud

Hi! Adding an "already assigned" or "taken" label would help to see which ones are already assigned instead of looking through comments to see if someone is already working on an issue :)

maribelduran avatar Oct 16 '17 23:10 maribelduran

Also thanks for putting this together!

maribelduran avatar Oct 16 '17 23:10 maribelduran

Thanks @maribelduran !! I will do that! Definitely should have thought of that one 😂

BlakeGuilloud avatar Oct 16 '17 23:10 BlakeGuilloud

At the end of Day 1 we're at npm version 2.0.6 with 24 merged in Pull Requests from 15 Contributors! Thanks everyone!

BlakeGuilloud avatar Oct 17 '17 04:10 BlakeGuilloud

@BlakeGuilloud just wanted to say I think this is a tremendous way to welcome beginners to the open source community while also promoting Hacktoberfest!

Great idea and excellent execution. :+1:

GabrielFabian avatar Oct 17 '17 04:10 GabrielFabian

Thanks @GabrielFabian !

BlakeGuilloud avatar Oct 17 '17 04:10 BlakeGuilloud

@BlakeGuilloud There are some skeleton methods that do not have GitHub issues. It would be great if we created issues for those so people could start working on them.

MahendraTennakoon avatar Oct 21 '17 02:10 MahendraTennakoon

Hey @MahendraTennakoon !! If you find any that do not have issues, feel free to open one! I try to keep up with them as best I can, but don't feel the need to wait on me!! Thanks for your contributions.

BlakeGuilloud avatar Oct 21 '17 02:10 BlakeGuilloud

Will this continue in some way after halloween? And thanks @BlakeGuilloud, I learn to contribute to the open source world nice workflow you have here. :D

sebassdc avatar Oct 28 '17 16:10 sebassdc

Hey @sebassdc ! Yeah of course it will continue. I imagine things will slow down and we might get a little more strict on what we allow in. i.e. proper jsdocs, more test suites, etc.. I'll also be doing an audit on the project and seeing where we can improve methods / get rid of duplicate methods. I'm glad you like it!

BlakeGuilloud avatar Oct 28 '17 16:10 BlakeGuilloud

I'll stay here to check what can we do :D

sebassdc avatar Oct 28 '17 17:10 sebassdc

Hey @BlakeGuilloud , is it ok to submit pull requests for new skeletons + tests without working an existing issue to increase the pool size of available methods to work for everyone?

kylevv avatar Oct 29 '17 18:10 kylevv

Yeah absolutely @kylevv ! Thanks!!

BlakeGuilloud avatar Oct 29 '17 18:10 BlakeGuilloud

How cool is this? This little project made the Highest Pull Request Count Repos for hacktoberfest! Pretty sweet.

image

BlakeGuilloud avatar Oct 29 '17 20:10 BlakeGuilloud

@BlakeGuilloud I just wanted to say thanks for starting this project and for actively maintaining it even as the number of participants and pull requests skyrocketed. I'm so glad I found out about Hacktoberfest and then stumbled upon this project because it is a fantastic example of how thorough, approachable documentation (including contributing guidelines!) can help lower barriers to getting involved in open source development. Plus, it was fun (which I believe was even part of the stated Objective). Kudos!

emilyanndavis avatar Nov 02 '17 06:11 emilyanndavis

Hey thanks @emilyanndavis !! I really appreciate all of the contributions you have made to the project. I'm really happy with the way it turned out, and I hope that you continue to stay involved with it! If you have any suggestions and / or critiques, please feel free to share them here or directly to me at [email protected]!

BlakeGuilloud avatar Nov 02 '17 06:11 BlakeGuilloud

@BlakeGuilloud I also wanted to thank you for creating this repo to help beginners like me! By contributing to your repo, I learned to fork, clone, made changes, and submitted a pull request to someone else's project. I also loved being able to create tests with jest.

After I submitted my pull request to this repo, I got the confidence to look for other open source projects and started contributing to them as well. Now I am actively working with a team on an open source project that is helping the city of San Francisco prepare for a natural disaster. O and I received my Hacktoberfest t-shirt! woop woop!

Again thanks for putting this repo together and for being so supportive! <3

maribelduran avatar Nov 08 '17 01:11 maribelduran

That's awesome to hear @maribelduran !! That natural disaster project sounds great! Good luck!

BlakeGuilloud avatar Nov 11 '17 22:11 BlakeGuilloud

@BlakeGuilloud I would really like to thank you for providing this great opportunity for first time contributors like me who wanted to contribute to the open source. Hoping to contribute even more to this repo. And thanks for being supportive.

jsjain avatar Nov 12 '17 11:11 jsjain