Clock icon indicating copy to clipboard operation
Clock copied to clipboard

M3 navigation bar active indicator

Open BluePixel4k opened this issue 1 year ago • 7 comments

Describe the solution you'd like

Please add the active indicator from M3 to the navigation bar, like this:

Screenshot_20240926-090705_1_1

https://m3.material.io/components/navigation-bar/overview

Use case

Following the M3 guideline.

It's easier to see which menu is selected.


Thank you! :)

BluePixel4k avatar Sep 26 '24 19:09 BluePixel4k

I'm not sure I agree with this improvement, as it was deliberate to remove this pill for two reasons:

  • To clean up the interface;
  • To make the icon animations more prominent.

Moreover, other applications such as GitHub's do not display this type of indicator. We can't say that our application isn't modern, for example.

Finally, the icons and the texts of selected tabs are highlighted with an accent color, and the name at top left clearly indicates which tab we're in.

With all these reasons, I'm not sure that adding yet another indicator is necessary.

BlackyHawky avatar Sep 26 '24 20:09 BlackyHawky

Maybe this pill could be optionally enabled via a setting? Because for me, when I switch into this app, it's look's like something is missing in comparison to other material you apps.

I haven't installed the official Github app, but in the screenshots it doesn't look like the app follows the M3 guidelines. So it's not a fair comparison.

BluePixel4k avatar Sep 27 '24 08:09 BluePixel4k

When I use the GitHub application as an example, it's only because it has an bottom navigation menu.

In any case, don't worry, I'll take your request into account.

A setting can be added to the "Interface" settings.

BlackyHawky avatar Sep 28 '24 05:09 BlackyHawky

A setting can be added to the "Interface" settings.

That would be awesome, thank you!

BluePixel4k avatar Sep 28 '24 06:09 BluePixel4k

@BluePixel4k Can you test the attached apk and give me your opinion please?

Clock_2.8_beta-debug.zip

BlackyHawky avatar Sep 28 '24 07:09 BlackyHawky

@BlackyHawky Thanks a lot, looking good!

Maybe you could adjust the colors of the fonts and icons a bit in this mode. The Google Clock (left) and your Clock app (right) for comparison:

I mean, coloring the selected icon and font less and the unselected ones a bit more. But this is just fine tuning and not mandatory :)

BluePixel4k avatar Sep 28 '24 09:09 BluePixel4k

Maybe you could adjust the colors of the fonts and icons a bit in this mode.

It seems to come from your device accent color. Here's what it looks like on mine (Android 12):

Day mode Night mode

You can see that the color contrast is good.

I have to test with my tablet with Android 14 ; not sure I'll change the other colors.

BlackyHawky avatar Sep 28 '24 10:09 BlackyHawky

After a few tests on my tablet using different accent colors, the contrast is good so I won't be changing the colors of the icons or anything else.

BlackyHawky avatar Sep 28 '24 17:09 BlackyHawky

Yes, overall the contrast is good, but I would prefer that the unselected menus get a quiet Monet color (currently they look static) and the selected one get a less intensive color than they have now. Do you know what I mean?

BluePixel4k avatar Sep 29 '24 08:09 BluePixel4k

Do you know what I mean?

No I don't.

In any case, when I see your screenshots, the color difference is too small for me to waste time working on it. And I'm not sure that when we switch between 2 different applications, we'll be surprised by the current colors. Finally, as you said above: "But this is just fine tuning and not mandatory :)"

BlackyHawky avatar Sep 29 '24 19:09 BlackyHawky