startbootstrap icon indicating copy to clipboard operation
startbootstrap copied to clipboard

Implemented SQLite parser plugin for Android's app_usage database

Open rick-slin opened this issue 9 months ago • 4 comments

One line description of pull request

Implemented SQLite parser plugin for Android's app_usage database.

Description:

Notes:

All contributions to Plaso undergo code review. This makes sure that the code has appropriate test coverage and conforms to the Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in order, and then a maintainer will review your code.

Checklist:

  • [ ] Automated checks (GitHub Actions, AppVeyor) pass
  • [x] No new new dependencies are required or l2tdevtools has been updated
  • [x] Reviewer assigned

rick-slin avatar May 01 '24 18:05 rick-slin

Thanks for the PR, I'll take a look as time permits.

joachimmetz avatar May 02 '24 04:05 joachimmetz

rebased with upstream for failing CI tests

joachimmetz avatar May 05 '24 10:05 joachimmetz

@rick-slin PTAL, CI tests are failing with

======================================================================
FAIL: testParsersAndPresets (data.presets.PresetsDataTest)
Tests that all parsers/plugins in presets.yaml are valid.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/plaso/plaso/tests/data/presets.py", line 32, in testParsersAndPresets
    self.assertFalse(invalid_parser_elements, msg=error_message)
AssertionError: {'sqlite/android_app_usage'} is not false : Invalid parser/plugin name(s) in preset: android

----------------------------------------------------------------------

joachimmetz avatar May 05 '24 11:05 joachimmetz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.11%. Comparing base (32ae7ba) to head (ecd86bc). Report is 2 commits behind head on main.

:exclamation: Current head ecd86bc differs from pull request most recent head fc34d5a

Please upload reports for the commit fc34d5a to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4881      +/-   ##
==========================================
+ Coverage   85.10%   85.11%   +0.01%     
==========================================
  Files         428      429       +1     
  Lines       38836    38861      +25     
==========================================
+ Hits        33051    33077      +26     
+ Misses       5785     5784       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 05 '24 17:05 codecov[bot]