startbootstrap icon indicating copy to clipboard operation
startbootstrap copied to clipboard

Add Container Runtime Interface log parser

Open sydp opened this issue 11 months ago • 4 comments

One line description of pull request

Adds support for the CRI text log format seen in GKE.

Description:

Related issue (if applicable): fixes #4616

Notes:

All contributions to Plaso undergo code review. This makes sure that the code has appropriate test coverage and conforms to the Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in order, and then a maintainer will review your code.

Checklist:

  • [x] Automated checks (GitHub Actions, AppVeyor) pass
  • [x] No new new dependencies are required or l2tdevtools has been updated
  • [x] Reviewer assigned

sydp avatar Sep 04 '23 08:09 sydp

This is dependent on ~https://github.com/log2timeline/dfdatetime/pull/264~ https://github.com/log2timeline/dfdatetime/pull/270

sydp avatar Dec 07 '23 10:12 sydp

Thanks for the PR, I'll take a look as time permits.

joachimmetz avatar May 02 '24 04:05 joachimmetz

CI tests are failing with

======================================================================
FAIL: testProcess (parsers.text_plugins.cri.CRILogTextPluginTest.testProcess)
Tests for the CheckRequiredFormat method.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "C:\projects\plaso\tests\parsers\text_plugins\cri.py", line 23, in testProcess
    self.assertEqual(number_of_event_data, 2)
AssertionError: 12 != 2
----------------------------------------------------------------------

joachimmetz avatar May 02 '24 14:05 joachimmetz

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.13%. Comparing base (e349697) to head (0716dca). Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4742      +/-   ##
==========================================
- Coverage   85.21%   85.13%   -0.08%     
==========================================
  Files         428      430       +2     
  Lines       38826    38908      +82     
==========================================
+ Hits        33084    33123      +39     
- Misses       5742     5785      +43     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 06 '24 08:05 codecov[bot]