startbootstrap
startbootstrap copied to clipboard
implemented DateLessLogFormatHelper
One line description of pull request
Implemented DateLessLogFormatHelper to retreive a date based on the modified, changed and creation time of a file.
Description:
Implemented DateLessLogFormatHelper to retreive a date based on the modified, changed and creation time of a file.
Related issue (if applicable): fixes #4697
Notes:
All contributions to Plaso undergo code review. This makes sure that the code has appropriate test coverage and conforms to the Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in order, and then a maintainer will review your code.
Checklist:
- [ ] Automated checks (GitHub Actions, AppVeyor) pass
- [x] No new new dependencies are required or l2tdevtools has been updated
- [x] Reviewer assigned
Codecov Report
Attention: Patch coverage is 88.13559%
with 14 lines
in your changes are missing coverage. Please review.
Project coverage is 85.25%. Comparing base (
ed8a139
) to head (928605e
).
Files | Patch % | Lines |
---|---|---|
plaso/engine/timeliner.py | 78.84% | 11 Missing :warning: |
plaso/lib/dateless_helper.py | 94.23% | 3 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #4699 +/- ##
========================================
Coverage 85.24% 85.25%
========================================
Files 426 427 +1
Lines 38532 38643 +111
========================================
+ Hits 32847 32944 +97
- Misses 5685 5699 +14
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@rick-slin FYI I'll start looking at merging this after the March release I might combine it with the yearless log helper into 1
@rick-slin unfortunately there are some shortcomings in the current design/approach, I'll need to take a closer look at a later time how to best implement support for date and time formats without a date.
Closing in favor of https://github.com/log2timeline/plaso/pull/4851