startbootstrap icon indicating copy to clipboard operation
startbootstrap copied to clipboard

Chrome cache payloads

Open chb2mn opened this issue 1 year ago • 2 comments

One line description of pull request

Chrome:cache:entry events only consist of url + time. I wanted to add some richness to that

Description:

I wanted to include some information about the actual payload in the cache. So this includes human-readable information about the datastream(s) behind an entry. The data streams are either internal (data_N (offset: 0x123456)) or external (f_012345).

Notes:

@joachimmetz I wanted your opinion on how to format the payload. Right now it's just a json.dumps(my_list), but there's probably a more elegant way of adding the info to the event.

Checklist:

  • [ ] Automated checks (GitHub Actions, AppVeyor) pass
  • [ ] No new new dependencies are required or l2tdevtools has been updated
  • [ ] Reviewer assigned

chb2mn avatar Jun 21 '23 19:06 chb2mn

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.12% :warning:

Comparison is base (d6022f8) 86.12% compared to head (7a19acc) 86.01%.

:exclamation: Current head 7a19acc differs from pull request most recent head d708c55. Consider uploading reports for the commit d708c55 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4696      +/-   ##
==========================================
- Coverage   86.12%   86.01%   -0.12%     
==========================================
  Files         416      416              
  Lines       37446    37344     -102     
==========================================
- Hits        32252    32123     -129     
- Misses       5194     5221      +27     
Files Changed Coverage Δ
plaso/parsers/chrome_cache.py 81.98% <100.00%> (+1.98%) :arrow_up:

... and 75 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 21 '23 20:06 codecov[bot]

@chb2mn must have missed this earlier, looks like this PR has a merge conflict This branch has conflicts that must be resolved could you PTAL. I'll try to have a closer look at the PR shortly.

joachimmetz avatar Aug 26 '23 03:08 joachimmetz