startbootstrap
startbootstrap copied to clipboard
Created parser for Apple IPS files.
One line description of pull request
Created parser for Apple IPS files as well as an IPS parser plugin for recoverylogd-[...].ips files.
Description:
Created parser for Apple IPS files as well as an IPS parser plugin for recoverylogd-[...].ips files.
Related issue (if applicable): fixes #<4102>
Notes:
All contributions to Plaso undergo code review. This makes sure that the code has appropriate test coverage and conforms to the Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in order, and then a maintainer will review your code.
Checklist:
- [x] Automated checks (GitHub Actions, AppVeyor) pass
- [x] No new new dependencies are required or l2tdevtools has been updated
- [x] Reviewer assigned
Codecov Report
Attention: Patch coverage is 91.75824%
with 15 lines
in your changes are missing coverage. Please review.
Project coverage is 85.20%. Comparing base (
e349697
) to head (271c16a
). Report is 5 commits behind head on main.
:exclamation: Current head 271c16a differs from pull request most recent head 35d376b. Consider uploading reports for the commit 35d376b to get more accurate results
Additional details and impacted files
@@ Coverage Diff @@
## main #4688 +/- ##
==========================================
- Coverage 85.21% 85.20% -0.02%
==========================================
Files 428 431 +3
Lines 38826 38818 -8
==========================================
- Hits 33084 33073 -11
- Misses 5742 5745 +3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Could someone please take another look at this PR?
@rick-slin thanks for the reminder. I'll try to take a look as soon as time permits, but note things are busy on my end.
Rebased with HEAD of origin main
I don't understand what needs to be fixed. What is a "non-mergeable pull request "?
I don't understand what needs to be fixed. What is a "non-mergeable pull request "?
do you mean the message in continuous-integration/appveyor/pr — AppVeyor was unable to build non-mergeable pull request
?
Don't worry about it, could be a fluke in the CI interaction, I'll have a look when I have time
Yes. This is what I meant. Thanks.
@rick-slin FYI I'll start looking at merging this after the March release
Yeah, no rush obviously. I just noticed that one of your last commits fixed an issue I was encountering in the CI tests.