startbootstrap icon indicating copy to clipboard operation
startbootstrap copied to clipboard

PostgreSQL log parser

Open Fryyyyy opened this issue 3 years ago • 2 comments

One line description of pull request

Parser for PostgreSQL log files

Description:

Tested with 9.5 and 10 Note that Amazon RDS uses a different format: https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/USER_LogAccess.Concepts.PostgreSQL.html

Related issue (if applicable): Fixes #4120

Notes:

All contributions to Plaso undergo code review. This makes sure that the code has appropriate test coverage and conforms to the Plaso style guide.

One of the maintainers will examine your code, and may request changes. Check off the items below in order, and then a maintainer will review your code.

Checklist:

  • [ ] Automated checks (Travis, Codecov, Codefactor )pass
  • [ ] No new new dependencies are required or l2tdevtools has been updated
  • [ ] Reviewer assigned

Fryyyyy avatar Jul 29 '22 05:07 Fryyyyy

Codecov Report

Base: 85.71% // Head: 85.72% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (50c4c12) compared to base (210eadd). Patch coverage: 90.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4175      +/-   ##
==========================================
+ Coverage   85.71%   85.72%   +0.01%     
==========================================
  Files         411      412       +1     
  Lines       35066    35149      +83     
==========================================
+ Hits        30056    30133      +77     
- Misses       5010     5016       +6     
Impacted Files Coverage Δ
plaso/parsers/postgresql.py 90.36% <90.36%> (ø)
plaso/output/formatting_helper.py 90.41% <0.00%> (+0.91%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Jul 29 '22 07:07 codecov[bot]

@joachimmetz PTAL

Took a quick look, left some comments, mostly style nits.

joachimmetz avatar Sep 22 '22 04:09 joachimmetz

Yeah I dunno why this isn't passing, it works on my machine :-/

Fryyyyy avatar Sep 23 '22 07:09 Fryyyyy

maybe UnknownTimezoneWarning: tzname AEST identified but not understood. Pass tzinfos argument in order to correctly return a timezone-aware datetime. In a future version, this will raise an exception.

I assume this should be 'Australia/Sydney'

joachimmetz avatar Sep 23 '22 17:09 joachimmetz

@joachimmetz is this waiting on me for anything?

Fryyyyy avatar Sep 28 '22 22:09 Fryyyyy

no this is waiting for me to have a free moment to take a last close look

joachimmetz avatar Sep 29 '22 03:09 joachimmetz