startbootstrap
startbootstrap copied to clipboard
implemented ips_parser and ips_parser plugin application_crash_log
One line description of pull request
implemented ips_parser and ips_parser plugin application_crash_log
Description:
implemented ips_parser and ips_parser plugin application_crash_log
Related issue (if applicable): fixes #<4102 >
Notes:
All contributions to Plaso undergo code review. This makes sure that the code has appropriate test coverage and conforms to the Plaso style guide.
One of the maintainers will examine your code, and may request changes. Check off the items below in order, and then a maintainer will review your code.
Checklist:
- [x] Automated checks (Travis, Codecov, Codefactor )pass
- [x] No new new dependencies are required or l2tdevtools has been updated
- [x] Reviewer assigned
@rick-slin please update with HEAD main, some issue for redis dependency has been addressed that affects the CI tests
Codecov Report
Base: 85.67% // Head: 85.66% // Decreases project coverage by -0.00%
:warning:
Coverage data is based on head (
aedfad3
) compared to base (662ec26
). Patch coverage: 84.61% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #4112 +/- ##
==========================================
- Coverage 85.67% 85.66% -0.01%
==========================================
Files 402 405 +3
Lines 34451 34620 +169
==========================================
+ Hits 29515 29658 +143
- Misses 4936 4962 +26
Impacted Files | Coverage Δ | |
---|---|---|
plaso/parsers/ips_plugins/interface.py | 78.26% <78.26%> (ø) |
|
plaso/parsers/ips_parser.py | 81.57% <81.57%> (ø) |
|
plaso/parsers/ips_plugins/application_crash_log.py | 90.00% <90.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Rebased with HEAD
- fixed numerous merge conflicts
- corrected more lower case ips and other issues in docstrings
@rick-slin could you PTAL at the open questions. Some parts of the implementation are not clear to me.
@rick-slin do you have more examples of ips log files you can share, so I can have a closer looks at some format variants
@rick-slin what is the status of this? Should I close this PR for now and reopen when you have the time work on it?
Yes @joachimmetz. I think this is for the best. It will be a while before I can return to this project.
@rick-slin thx for the update. If you have additional examples of ips log files you can share that would be useful for when I have a cycle to look at this.
Closing PR for now as discussed.