sql-to-jdl icon indicating copy to clipboard operation
sql-to-jdl copied to clipboard

Published 20 hours ago • verified publisher icon Blackdread

add postgres DB support

Open jeb-dev opened this issue 3 years ago • 4 comments

jeb-dev avatar Apr 27 '21 15:04 jeb-dev

@jeb-dev Thanks for the PR Why remove the jooq type safe query and replace by string? If it is to support postgres, was it not safer to define another repository and then configure the bean at runtime depending on profile (since you use profile) -> annotation @Profile('xxx')

Would be great if can add a test with postgres, there are already different tests for each DB type

Blackdread avatar Apr 28 '21 03:04 Blackdread

Thank you for your comment I will imporve that

jeb-dev avatar Apr 28 '21 07:04 jeb-dev

Hi @Blackdread, it looks as if this feature branch hasn't had any additional updates, since the the April dialogues. Do you have any plans to apply similar changes yourself? I'm currently working on several jhipster applications, which could do with being based around postgres instead of mysql. Many thanks, Jonathan.

jonathanmclarke avatar Sep 18 '21 00:09 jonathanmclarke

hi, I have not a lot of time to test this branch. If you can copy the code and add an integration test that shows it works with postgres and still works with other dbs then I will merge

Blackdread avatar Sep 18 '21 00:09 Blackdread

Probably should close this PR as fixed by https://github.com/Blackdread/sql-to-jdl/pull/129

octgsoftware avatar Nov 17 '22 14:11 octgsoftware