sql-to-jdl icon indicating copy to clipboard operation
sql-to-jdl copied to clipboard

feat: Added GroupedRelation empty filter

Open rlcc885 opened this issue 1 year ago • 4 comments

(cherry picked from commit f01088d8a53aca6496051120f02ce0acdfb9e67a)

rlcc885 avatar Oct 22 '24 05:10 rlcc885

Hi, what was it for exactly?

Blackdread avatar Oct 24 '24 11:10 Blackdread

Hi, nice to meet you, when you select the option to group export-file-structure-type: GROUPED_RELATIONS_SEPARATE_VIEWS one-to-one or one-to-many relationships, but they do not exist as such in the schema, empty structures are generated. For example:

relationship ManyToOne {
}
relationship OneToOne {
}

The commit tries to solve it

rlcc885 avatar Oct 24 '24 20:10 rlcc885

Alright. Why did you decide to close your PR ?

After, the fact that empty ones are generated, I do not mind it, it makes it clear that none were seen/found by the code logic.

Blackdread avatar Oct 24 '24 20:10 Blackdread

Of course, at the programming level there is no problem, but when using the web version of the jdl editor, it marks an error when generating the relationship structure as empty. The focus of the commit was aiming at web integration. Regarding the reason for closing the PR, it is because I made a missclick to the fork of my account, but I could generate a new one.

rlcc885 avatar Oct 24 '24 21:10 rlcc885