sql-to-jdl icon indicating copy to clipboard operation
sql-to-jdl copied to clipboard

Add Lombok to reduce boilerplate code and add a builder pattern

Open octgsoftware opened this issue 2 years ago • 3 comments

octgsoftware avatar Dec 18 '22 15:12 octgsoftware

Not much real value in Lombok, I have used it, it has good things but the reality is it does not provide that much added value, this is a small project. And for big projects, I would definitely not go for Lombok.

I am not against it, just to say this is small project, not much gain from adding Lombok, it adds complexity.

Blackdread avatar Dec 18 '22 18:12 Blackdread

Agreed that it adds complexity, but it can do some really cool things with minimal code. Personally, I have never run into any problems. If problems arose, delombok could be used and the boiler plate code merged back in manually.

This is not a priority. However, if you would accept a PR then I would likely see what I could come up with.

I wanted to do more tests like src/test/java/org/blackdread/sqltojava/test/general/MustacheTest.java, and a builder pattern would be a lot more readable.

octgsoftware avatar Dec 18 '22 19:12 octgsoftware

If a PR is made, I can agree to merge. Project is small so not much impact; in other personal or work projects, none have Lombok.

Blackdread avatar Dec 18 '22 22:12 Blackdread