GoodTwitter2 icon indicating copy to clipboard operation
GoodTwitter2 copied to clipboard

stopped working?

Open MaximzMugen opened this issue 3 years ago • 33 comments

it just randomly stopped working, im on chrome Version 90.0.4430.72 (Official Build) (64-bit) and lastest stable build of tampermonkey, but goodtwitter2 just stopped working, it was working last week and then 4 days ago it stopped, then last night i updated chrome and it worked again, and it stopped working again today

MaximzMugen avatar Apr 15 '21 19:04 MaximzMugen

I just updated to Chrome 90.0.4430.72 and have no issues. The last Tampermonkey update broke some other script I use without explanation, maybe this is the same issue... Please try deactivating and then activating TM again, this fixed it for me.

Possibly related: https://github.com/Tampermonkey/tampermonkey/issues/1213

Bl4Cc4t avatar Apr 15 '21 21:04 Bl4Cc4t

ohhh i see, yea deactivating Tampermonkey and reactivating solves it, i hope this doesnt mean i'll have to do that everytime i reboot though haha

MaximzMugen avatar Apr 15 '21 23:04 MaximzMugen

I didn't have to do that for that other script that broke, I guess you don't have to do so either :D

I'll leave this open in case someone has the same issue

Bl4Cc4t avatar Apr 16 '21 08:04 Bl4Cc4t

Had this problem too yesterday. Deactivating and activating helped but after closing the browser I had to do it again

WeyP96 avatar Apr 16 '21 22:04 WeyP96

@WeyP96 That's odd. Have you tried reinstalling this script?

Bl4Cc4t avatar Apr 17 '21 22:04 Bl4Cc4t

Yeah I did, the problem I have seems to be very peculiar, when I open twitter from a new tab with the normal url it shows me the shit twitter, but if I click on it via a link that ends with ?s=20 it goes to goodtwitter and when I click on the home button it stays on goodtwitter. Kinda weird

WeyP96 avatar Apr 18 '21 02:04 WeyP96

so, after you told me to disable and re-enable tampermonkey it continued to work even after rebooting my computer for 2 days but then today i just turned on my computer n went to twitter and it stopped working again so i had to disable and re-enable tamper monkey again.

MaximzMugen avatar Apr 18 '21 02:04 MaximzMugen

I just had the same issue with the other script I mentioned again.

@WeyP96 @MaximzMugen Since this seems to be an issue with TM, you could try switching to Violentmonkey for the time being.

Bl4Cc4t avatar Apr 18 '21 09:04 Bl4Cc4t

I'll switch to that and tell you if it helped or not after some days

WeyP96 avatar Apr 18 '21 16:04 WeyP96

Been using it for a day and more and no problems since switching to violentmonkey!

WeyP96 avatar Apr 19 '21 17:04 WeyP96

Cool, thanks for the update! Hope the issue gets resolved soon though.

Bl4Cc4t avatar Apr 20 '21 12:04 Bl4Cc4t

it stopped working and turning tampermonkey on and off again wont fix it.

DcSensai avatar Dec 11 '21 18:12 DcSensai

it stopped working and turning tampermonkey on and off again wont fix it.

I'm experiencing the same issue. I'm on Firefox and just restarted my browser, and on restart, GoodTwitter2 stopped working, even though it was working until the restart (I had last refreshed a twitter page just minutes prior). I have two other userscripts enabled in tampermonkey, and they work, but GoodTwitter2 doesn't.

barbedknot avatar Dec 11 '21 19:12 barbedknot

@DcSensai @barbedknot no problems on my end. are there any errors in the console?

Bl4Cc4t avatar Dec 11 '21 23:12 Bl4Cc4t

@DcSensai @barbedknot no problems on my end. are there any errors in the console?

Sorry, will you please spell it out for me how one can check?

barbedknot avatar Dec 11 '21 23:12 barbedknot

@DcSensai @barbedknot no problems on my end. are there any errors in the console?

how can i find the console so i can check. and yes i am on firefox as well.

DcSensai avatar Dec 11 '21 23:12 DcSensai

@DcSensai @barbedknot oh, sorry. press F12 and click on "console" image


Twitter will show you lots of warnings (yellow), these are usually not very useful. You can turn them off by clicking on "warnings" image

then you can make a screenshot of the errors if there are any and share that here :)

Bl4Cc4t avatar Dec 12 '21 00:12 Bl4Cc4t

@Bl4Cc4t I disabled ublock origin (because it also produced red errors), clicked the "warnings" button, and clicked the red exclamation mark, and I still see this. Untitled

Uncaught (in promise) TypeError: key.toKebab is not a function updateCSS moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3418 urlChange moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3605 tms_167077e8_e069_44e9_9f2c_7b6a4d3d3150 moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3784 tms_167077e8_e069_44e9_9f2c_7b6a4d3d3150 moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3814 We https://twitter.com/:13 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:1 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:1 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3816 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3818 E_u https://twitter.com/:3 create https://twitter.com/ line 2 > eval:68 create https://twitter.com/ line 2 > eval:69 i https://twitter.com/ line 2 > eval:5 We https://twitter.com/:13 a https://twitter.com/ line 2 > eval:3 s https://twitter.com/ line 2 > eval:3 w https://twitter.com/:6 w https://twitter.com/:6 line 3 > eval:3418:52

barbedknot avatar Dec 12 '21 00:12 barbedknot

its giving me errors, however unlike @barbedknot i already had ublock origin off. error report

DcSensai avatar Dec 12 '21 06:12 DcSensai

Also I wanted to add that I rarely (never willingly) close my browser, so I can't say anything about when this started happening. My firefox didn't update when this error started happening. I had only coincidentally restarted my browser today because my CPU usage was 100% and my ram usage was inordinately high.

barbedknot avatar Dec 12 '21 06:12 barbedknot

@DcSensai @barbedknot thank you for this, now we have an error to work with. can you please now do the following:

  • go to twitter.com
  • click the following: image
  • replace the full text in the editor you now see with this one here
  • go back to twitter and reload
  • please post again what the console says, there should now be something like this before the error happens: image

when you're done, you can reinstall the normal script so that the updates work again.

Bl4Cc4t avatar Dec 12 '21 13:12 Bl4Cc4t

@Bl4Cc4t

I had to click "File" > "Save" to save the tampermonkey edit, at which point a banner at the top of the page flashed saying it saved, but here's what I see after doing that: Untitled

[init] home GoodTwitter 2 - Electric Boogaloo.user.js:3598:13 key: "disableAutoRefresh", val: "false" GoodTwitter 2 - Electric Boogaloo.user.js:3420:17 key: "forceLatest", val: "false" GoodTwitter 2 - Electric Boogaloo.user.js:3420:17 key: "keepTweetsInTL", val: "true" GoodTwitter 2 - Electric Boogaloo.user.js:3420:17 Uncaught (in promise) TypeError: key.toKebab is not a function updateCSS moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3421 urlChange moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3613 tms_167077e8_e069_44e9_9f2c_7b6a4d3d3150 moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3792 tms_167077e8_e069_44e9_9f2c_7b6a4d3d3150 moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3822 We https://twitter.com/home:13 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:1 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:1 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3824 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3826 E_u https://twitter.com/home:3 create https://twitter.com/home line 2 > eval:68 create https://twitter.com/home line 2 > eval:69 i https://twitter.com/home line 2 > eval:5 We https://twitter.com/home:13 a https://twitter.com/home line 2 > eval:3 s https://twitter.com/home line 2 > eval:3 w https://twitter.com/home:6 w https://twitter.com/home:6 home line 3 > eval:3421:52

barbedknot avatar Dec 12 '21 13:12 barbedknot

@Bl4Cc4t

when you're done, you can reinstall the normal script so that the updates work again.

What do you mean by "reinstall the normal script"? When I go to here: https://github.com/Bl4Cc4t/GoodTwitter2#installation

and click the link that prompts with the "installation screen", it does have a "reinstall" button. But, my console still shows the same error, and GoodTwitter2 still doesn't work, even after restarting my browser.

barbedknot avatar Dec 12 '21 14:12 barbedknot

@barbedknot thank you. I'm testing this on Firefox 95.0 and cannot reproduce this issue. What version of Firefox & Tampermonkey are you using?

The issue seems to lie within a helper function I'm using, so can you please check what happens when you paste the following two commands in the console window at twitter?

(12345678).humanizeShort() // should return "12.3M"
"thisIsAString".toKebab()  // should return "this-is-a-string"

What do you mean by "reinstall the normal script"?

I meant exactly what you did, because I thought I could fix the issue right away. Also, when you modify scripts yourself, their updates get broken sometimes, so it's better to reset them after troubleshooting.

Bl4Cc4t avatar Dec 12 '21 18:12 Bl4Cc4t

@Bl4Cc4t

Untitled

[init] home GoodTwitter 2 - Electric Boogaloo.user.js:3590:13 Uncaught (in promise) TypeError: key.toKebab is not a function updateCSS moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3418 urlChange moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3605 tms_167077e8_e069_44e9_9f2c_7b6a4d3d3150 moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3784 tms_167077e8_e069_44e9_9f2c_7b6a4d3d3150 moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3814 We https://twitter.com/home:13 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:1 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:1 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3816 <anonymous> moz-extension://2f9d3d67-54ae-4f0c-9a3b-b1ed526b001e/userscripts/GoodTwitter 2 - Electric Boogaloo.user.js?id=167077e8-e069-44e9-9f2c-7b6a4d3d3150:3818 E_u https://twitter.com/home:3 create https://twitter.com/home line 2 > eval:68 create https://twitter.com/home line 2 > eval:69 i https://twitter.com/home line 2 > eval:5 We https://twitter.com/home:13 a https://twitter.com/home line 2 > eval:3 s https://twitter.com/home line 2 > eval:3 w https://twitter.com/home:6 w https://twitter.com/home:6 home line 3 > eval:3418:52 (12345678).humanizeShort() // should return "12.3M" "thisIsAString".toKebab() // should return "this-is-a-string" Uncaught TypeError: 12345678.humanizeShort is not a function <anonymous> debugger eval code:1 debugger eval code:1:12

Edit: Sorry, I should add that I am on the latest version of Firefox (95.0, 64-bit), and on Tampermonkey BETA v4.14.6149

barbedknot avatar Dec 12 '21 18:12 barbedknot

@Bl4Cc4t i preformed the above steps attached is the errors i received after pasting in the script you provided, i refreshed after both pasting the script and reinstalling and neither have fixed the problem. error report 2

DcSensai avatar Dec 12 '21 20:12 DcSensai

I have this problem with Tampermonkey BETA v4.14.6149 in Firefox. Now I installed Tampermonkey v4.13.6136 (official release ver.) in parallel to beta, turned off the script in beta and install this version in the official one and it's work now!

BrandtnerKPW avatar Dec 12 '21 21:12 BrandtnerKPW

It was my fault for not asking what versions you are using, I should have done that in the beginning. Now I can reproduce the error.

It seems to only occur with Tampermonkey BETA, I suspect it introduced some kind of bug by accident. ~~I'll try to tackle it down and file an issue so it gets fixed.~~ Filed an issue here: https://github.com/Tampermonkey/tampermonkey/issues/1385

In the mean time, you can use the normal version if you want!

Also @BrandtnerKPW: I haven't actually changed anything in that file I provided, it was just for logging and seeing where the error happens :)

Bl4Cc4t avatar Dec 12 '21 23:12 Bl4Cc4t

Was about to come in and hope this was fixed. I verified that Beta had a recent automatic update which broke the script on my end. Thank you for the swift action as I would lose my mind having to use Twitter's horrid new interface.

nanakisan avatar Dec 16 '21 08:12 nanakisan

With TM Beta 4.14.6150, the script works again :)

Bl4Cc4t avatar Dec 18 '21 00:12 Bl4Cc4t