Binance: missing "Large OTC trading" operation

[doruchan]

Hi there,

The Binance parser doesn't understand the "Large OTC trading" operation, which is how a trade is being reported by the "Generate all statements" function in Binance. An example from my report:

UTC_Time | Account | Operation | Coin | Change | Remark
2021-03-03 03:46:40 | Spot | Large OTC trading | BNB | 0.40754612
2021-03-03 03:46:40 | Spot | Large OTC trading | BTC | -0.002

Thanks,

Dora

[doruchan]

It's also not recognising the "Deposit" operation, using the same statement. Example:

UTC_Time | Account | Operation | Coin | Change | Remark
2021-02-26 02:28:46 | Spot | Deposit | BTC | 0.00775438

[nanonano]

Hi @doruchan,

The statements export is only used for commissions, airdrops, bnb conversions, interest/staking.

For trades, crypto/fiat deposits, please use the different export formats as described here: https://github.com/BittyTax/BittyTax/issues/141#issuecomment-872207621

These exports provide more accurate data to decode that the statements format, I'll be adding a wiki page to cover this shortly.

Please let me know if OTC trades are included in the trades history export correctly?

[doruchan]

Hey @nanonano,

unfortunately Trade History is not showing this operation, but I found it in the "Convert History" section. Wouldn't be okay to support this from the "Generate all statements" document, since it's in there?

[nanonano]

Thanks for confirming, if it's only available in the Statements export, I'll get it added.

[doruchan]

Not sure if you saw it, but I've opened a PR for this issue: #192

[nanonano]

Hi @doruchan, this has been fixed by commit: https://github.com/BittyTax/BittyTax/commit/78881135f28c8edae551fd8234fd441ee596f41b, please can you re-test.

[nanonano]

Hi @doruchan just realised "Large OTC trading" trades can be exported via the Convert History which was added for issue #208.

I'm going to remove the handling of "Large OTC trading" from the Statements parser to prevent double accounting, the Convert History is a safer way to handle these trades since the buy and sell components are shown together in the same row of data.

[nanonano]

It's been removed by this change https://github.com/BittyTax/BittyTax/commit/677ea19c0659f76a1a718912a997fd044bfe9511.

[doruchan]

Thanks @nanonano. The main drive for me for adding this to the Statement parser is that you can generate it for the whole year by pressing 1 button, instead having to go to each history section and have to export only up to 3 months of statements.