PyBitmessage icon indicating copy to clipboard operation
PyBitmessage copied to clipboard

fixed the app closing issue on the press of quit button

Open navjotcis opened this issue 4 years ago • 3 comments

Here when user try to quit the app then the app does not close it takes time longer than expected so I have fixed it for two cases

  1. when the user open the app and closes it before the connection popup shows then the app does not close. It runs in a loop for n no. of times which takes sometimes 2-3 minutes or longer then it so I have added the condition with it for checking if the user presses quit then it will not go into the loop and close the app.
  2. This case appears sometimes so here also app not close when the user tries to quit because there is condition pendingDownload() > 0 so app-only close when pendingDownload() returns 0 or less so the value of pendingDownload() method is not fixed sometimes it gives a large no. which run in the loop N no. of times so also it does not close the app until loop executes N no. of times so I have also added the condition here when the user press the quit then it does not go into the loop and close the app.

navjotcis avatar Sep 18 '20 13:09 navjotcis

This isn't working correctly. I know I made recommendations, but at best they were incomplete. Find a way to fix this properly.

PeterSurda avatar Oct 13 '20 12:10 PeterSurda

I have tested all the scenarios and then I have made the table for all the cases and all are passed image

navjotcis avatar Oct 17 '20 16:10 navjotcis

I have changed the UI of the app closing popup and also when the user click on the Quit button I am showing a progress bar and on the press of don't quit progress bar will disappear. Fixes #1298

navjotcis avatar Oct 27 '20 18:10 navjotcis