Guide icon indicating copy to clipboard operation
Guide copied to clipboard

Wallet Improvements Project - Issue Tracker

Open pavlenex opened this issue 4 years ago • 8 comments

This issue will serve as a ticket tracker of all the issues we, as Bitcoin Design Community identify on our design review calls and beyond. The goal is to allow us central place to keep track of all improvements proposals and their implementation.

Maintainers feel free to edit this comment to add new issues to the list, and anyone else feel free to post a links to the issues you've identified.

The screens of wallets we're reviewing can be found in this Google Sheet.

Blixt Wallet

  • [ ] https://github.com/hsjoberg/blixt-wallet/issues/377
  • [x] https://github.com/hsjoberg/blixt-wallet/issues/378
  • [ ] https://github.com/hsjoberg/blixt-wallet/issues/379
  • [x] https://github.com/hsjoberg/blixt-wallet/issues/380
  • [ ] https://github.com/hsjoberg/blixt-wallet/issues/381
  • [x] https://github.com/hsjoberg/blixt-wallet/issues/382
  • [ ] https://github.com/hsjoberg/blixt-wallet/issues/383
  • [ ] https://github.com/hsjoberg/blixt-wallet/issues/384
  • [x] https://github.com/hsjoberg/blixt-wallet/issues/386

Bluewallet

  • [ ] https://github.com/BlueWallet/BlueWallet/issues/3885
  • [ ] https://github.com/BlueWallet/BlueWallet/issues/4353
  • [ ] https://github.com/BlueWallet/BlueWallet/issues/4463
  • [ ] BlueWallet/LndHub#368

Breez Wallet

  • [x] https://github.com/breez/breezmobile/issues/595
  • [x] https://github.com/breez/breezmobile/issues/597
  • [x] https://github.com/breez/breezmobile/issues/598
  • [x] https://github.com/breez/breezmobile/issues/599
  • [x] https://github.com/breez/breezmobile/issues/600

Phoenix Wallet

  • [ ] https://github.com/ACINQ/phoenix/issues/184
  • [ ] https://github.com/ACINQ/phoenix/issues/196
  • [ ] https://github.com/ACINQ/phoenix/issues/197
  • [x] https://github.com/ACINQ/phoenix/issues/198
  • [x] https://github.com/ACINQ/phoenix/issues/199
  • [ ] https://github.com/ACINQ/phoenix/issues/200
  • [x] https://github.com/ACINQ/phoenix/issues/204
  • [ ] https://github.com/ACINQ/phoenix/issues/205
  • [ ] https://github.com/ACINQ/phoenix/issues/208
  • [ ] https://github.com/ACINQ/phoenix/issues/248

Bitcoin Design Guide improvements

Bellow are improvements that we've added to the Bitcoin Design Guide based on the reviews we've performed.

  • [x] https://github.com/BitcoinDesign/Guide/issues/535
  • [x] https://github.com/BitcoinDesign/Guide/issues/536

pavlenex avatar Sep 24 '21 12:09 pavlenex

We might want to wait on Blue Wallet until the LDK version is released before providing UI feedback.

On Fri, Sep 24, 2021 at 5:30 AM Pavlenex @.***> wrote:

This issue will serve as a ticket tracker of all the issues we, as Bitcoin Design Community identify on our design review calls and beyond. The goal is to allow us central place to keep track of all improvements proposals and their implementation.

Maintainers feel free to edit this comment to add new issues to the list, and anyone else feel free to post a links to the issues you've identified.

The screens of wallets we're reviewing can be found in this Google Sheet. https://docs.google.com/spreadsheets/d/1EI2qvVhb2XqfN4Ms2oDN8zl9-ReZ0acw2fG4Gmj6OBY/edit?usp=sharing Bluewallet

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/BitcoinDesign/Guide/issues/493, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACPUAZV7FCKI27DC2EHCC3UDRVNLANCNFSM5EV3LI5A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

moneyball avatar Sep 24 '21 14:09 moneyball

I assume what Steve mentioned, refers to the Bluewallet and I agree, I guess the small nits can in the UI can still be ironed out as I don't think implementation would affect them, but we should hold off any major structural feedback and focus on other wallets until Bluewallet is released with LDK.

pavlenex avatar Sep 24 '21 14:09 pavlenex

Agreed. I mainly wanted to put together some examples for this initiative and hope that others join in. Roughly, I think we can discuss 4 levels of feedback:

  1. Use case & audience (what user problems are being solved, who are the users, product-market fit...)
  2. Spec (what features and tech is supported, are they appropriate for the use case...)
  3. Interaction (is it easy to understand, navigate, use...)
  4. Execution (layout, icons, colors...)

My examples were intentionally focused on the 4th type, as it's really easy to capture, discuss, and fix. Hopefully we get a few people to do these, I am curious what everyone thinks can be improved.

GBKS avatar Sep 24 '21 16:09 GBKS

Who's keen for another, I recommend Zap. They're remote node only on mobile but the desktop has a neutrino light client mode. Feedback is also relevant to Zeus redesign

Bosch-0 avatar Nov 24 '21 04:11 Bosch-0

@Bosch-0 Let's set up one this Thursday. I must admit I've been slacking for the past few weeks on this one.

pavlenex avatar Nov 24 '21 11:11 pavlenex

Lock it :)

Bosch-0 avatar Nov 25 '21 04:11 Bosch-0

@pavlenex just went through the unchecked links in the issue, all of them are still open.

The issue has gone a bit stale, but I think we can keep using it for any future issues we file with projects via the wallet design improvement project.

There are two additional issues I created with BlueWallet that were not part of the wallet improvement project. Should I add these here, too?

  • https://github.com/BlueWallet/BlueWallet/issues/4353
  • https://github.com/BlueWallet/BlueWallet/issues/4463

GBKS avatar Feb 10 '22 09:02 GBKS

Created issues where they did not exist for the zero amount invoice issue Steve brought up

  • https://github.com/ACINQ/phoenix/issues/248
  • BlueWallet/LndHub#368

Bosch-0 avatar Feb 12 '22 02:02 Bosch-0