Guide icon indicating copy to clipboard operation
Guide copied to clipboard

Contact page updates to mention new protocols

Open yashrajd opened this issue 5 months ago β€’ 3 comments

Fixes #1152

πŸ–₯️ Preview

yashrajd avatar Jun 06 '25 01:06 yashrajd

Deploy Preview for bitcoin-design-site ready!

Name Link
Latest commit 808d088cf62eacbbc871a35c0d062ae1b84cd2d8
Latest deploy log https://app.netlify.com/projects/bitcoin-design-site/deploys/685e72f816e75b00082db26c
Deploy Preview https://deploy-preview-1173--bitcoin-design-site.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Jun 06 '25 01:06 netlify[bot]

Just updated multiple mocks of the last image carousel in updating last carousel about supporting various formats (2 checks are neutral now, don't think that was the case before these latest commits {don't remember lol})...

yashrajd avatar Jun 16 '25 19:06 yashrajd

Just updated multiple mocks of the last image carousel in updating last carousel about supporting various formats (2 checks are neutral now, don't think that was the case before these latest commits {don't remember lol}) cc @GBKS ...

If these "neutral" checks are not a problem, and the updated mocks as well as intro udpates look okay to you guys, this might be ready to merge.

yashrajd avatar Jun 16 '25 19:06 yashrajd

Generally, I don't find the header image an improvement as it looks very complex now. But not going to push in any direction here, totally your call.

Simplified it by reducing the number of people on it.

In the manual-add-contact-add-address-on-chain-toggle-big.png image, can you please center the text so it's consistent with the other images in the gallery? If it's an input field, the address would probably also not be chunked and elided.

Done.

For the red color for when address types are not supported, as you probably know by now, I personally prefer only using red when there's something really wrong. Otherwise it loses its impact due to overuse. So I think the grey color (or blue) is fine. Just my view, also leaving this up to you.

Agree with your point about overuse but unsure what you mean by "something really wrong"...the copy on the screens says the payment formats "cannot be used" and "not supported", which IMO are valid error states, and the user will not be allowed to proceed to make a payment or save the contact. Hence I'm keeping those.

yashrajd avatar Jun 25 '25 22:06 yashrajd

Agree with your point about overuse but unsure what you mean by "something really wrong"

I mean stuff like the "delete wallet" function or it detected an address poisoning attack, etc. Where funds/privacy/security are at risk. Running into an input validation thing is not a big problem.

GBKS avatar Jun 26 '25 08:06 GBKS

A way that helps me think about it: I use red when the action is permanent or destructive, like deleting a contact or rejecting a request. For things like validation blockers or information alerts I tend to use more neutral colors like gray.

swedishfrenchpress avatar Jun 26 '25 08:06 swedishfrenchpress

A way that helps me think about it: I use red when the action is permanent or destructive, like deleting a contact or rejecting a request.

Agree that's a good way to think about it.

For things like validation blockers or information alerts I tend to use more neutral colors like gray.

I don't remember ever seeing error text in non-red. Both Apple/Google products and guidelines use or suggest using red for error text. Examples below.

IMG_92ABF4665E24-1

ioejkhbgjd

yashrajd avatar Jun 26 '25 17:06 yashrajd

I'd appreciate if the PR could focus on its goal of mentioning new protocols, and stick with the UI standards that are already established on this page (and the daily spending wallet in general). It makes it harder for a reader if things change from one screen or section to another.

GBKS avatar Jun 27 '25 06:06 GBKS

I'd appreciate if the PR could focus on its goal of mentioning new protocols, and stick with the UI standards that are already established on this page (and the daily spending wallet in general). It makes it harder for a reader if things change from one screen or section to another.

got it, reverted.

yashrajd avatar Jun 27 '25 10:06 yashrajd

A way that helps me think about it: I use red when the action is permanent or destructive, like deleting a contact or rejecting a request.

Agree that's a good way to think about it.

For things like validation blockers or information alerts I tend to use more neutral colors like gray.

I don't remember ever seeing error text in non-red. Both Apple/Google products and guidelines use or suggest using red for error text. Examples below.

IMG_92ABF4665E24-1

ioejkhbgjd

I don’t really see Apple or Google as the standard for UI design anymore. Especially Apple which I think has really dropped in quality. Linear has become my northstar in terms of best design practices for UI. But in the end it’s a personal preference.

swedishfrenchpress avatar Jun 28 '25 07:06 swedishfrenchpress

lol I was about to make these changes

yashrajd avatar Jul 02 '25 22:07 yashrajd

Sorry for the premature close and merge. Can we open a new PR for these changes?

On Thu, Jul 3, 2025 at 00:40 @.*** @.***> wrote:

yashrajd left a comment (BitcoinDesign/Guide#1173) https://github.com/BitcoinDesign/Guide/pull/1173#issuecomment-3029530650

lol I was about to make these changes

β€” Reply to this email directly, view it on GitHub https://github.com/BitcoinDesign/Guide/pull/1173#issuecomment-3029530650, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASZLNPI4VRUSBUYH7BMIFYD3GRNXNAVCNFSM6AAAAAB6W337FSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMRZGUZTANRVGA . You are receiving this because you modified the open/close state.Message ID: @.***>

swedishfrenchpress avatar Jul 02 '25 22:07 swedishfrenchpress