bitcoin-abc icon indicating copy to clipboard operation
bitcoin-abc copied to clipboard

Published 20 hours ago • verified publisher icon Bitcoin-ABC

rpcRunLater race in walletpassphrase

Open kryvel opened this issue 5 years ago • 5 comments
trafficstars

Hi, I encountered with deadlock on concurrent walletpassphrase rpc call in bitcoin wallet. The same behavior in bitcoin-abc too. Here is a description of the issue https://github.com/bitcoin/bitcoin/issues/18482

Could you please backport the fix to bitcoin-abc ?

kryvel avatar Apr 02 '20 00:04 kryvel

Thanks for bringing this to our attention. We'll keep tabs on the that developing issue and it's associated fix.

jasonbcox avatar Apr 02 '20 03:04 jasonbcox

I could confirm, that test case, provided in #18482, shows that issue is present in bitcoin-abc latest version, and the suggested fix is working. After compiling with fixed rpcwallet.cpp issue is gone.

kryvel avatar Apr 03 '20 20:04 kryvel

HI, @jasonbcox Any update on this? Is it planned to include it to the next release ?

kryvel avatar Apr 21 '20 17:04 kryvel

Sorry for the delay. The fix is now under review: https://reviews.bitcoinabc.org/D7908 I expect the fix will make it in the next release (0.22.5) which comes out on October 27th.

jasonbcox avatar Oct 13 '20 16:10 jasonbcox

The change has landed on master. If you want to test it before the 0.22.5 release, can you try latest master and confirm the fix?

jasonbcox avatar Oct 13 '20 21:10 jasonbcox