AmongUsMenu icon indicating copy to clipboard operation
AmongUsMenu copied to clipboard

Rare crash when unhooking

Open kotae4 opened this issue 2 years ago • 0 comments

there is bug: https://github.com/BitCrackers/AmongUsMenu/blob/main/hooks/_hooks.cpp#L169 look at impl: https://github.com/BitCrackers/AmongUsMenu/blob/main/includes/detours/detours.cpp#L1937 if thread is within patched bytes when unhooking occurs then it'll crash. need to suspend every other thread and relocate instruction ptr if in trampoline. the detours library does this but only if you call DetourUpdateThread for each other thread.

kotae4 avatar May 20 '22 12:05 kotae4