bitbox-wallet-app icon indicating copy to clipboard operation
bitbox-wallet-app copied to clipboard

refactor: remove obsolete // +build tag

Open xiaolinny opened this issue 1 month ago • 3 comments

Before asking for reviews, here is a check list of the most common things you might need to consider:

  • [ ] updating the Changelog
  • [ ] writing unit tests
  • [ ] checking if your changes affect other coins or tokens in unintended ways
  • [ ] testing on multiple environments (Qt, Android, ...)
  • [ ] having an AI review your changes

From Go 1.17, the preferred syntax for build constraints is //go:build, which replaces the old // +build form. The old style is now considered deprecated but still supported for backward compatibility.

This change removes the obsolete // +build xxx line, keeping only the modern //go:build xxx directive.

More info: https://github.com/golang/go/issues/41184 and https://go.dev/doc/go1.17#build-lines

Design Doc / Proposal: https://go.dev/design/draft-gobuild

xiaolinny avatar Nov 10 '25 07:11 xiaolinny

There are more instances of this.

Oh, indeed. Thank you for your reminder. 😄 @benma

I've made all the modifications. Please review again.

xiaolinny avatar Nov 13 '25 06:11 xiaolinny

@benma Please review it again. If there's anything need I to do, please feel free to let me know.

xiaolinny avatar Dec 08 '25 07:12 xiaolinny

@xiaolinny for my info/curiosity, how did this contribution come about? Is there some sort of contribution reward program/airdrop going on? If so, which one?

benma avatar Dec 09 '25 15:12 benma

@xiaolinny for my info/curiosity, how did this contribution come about? Is there some sort of contribution reward program/airdrop going on? If so, which one?

There was no reward. But I'm new to web3 and need to learn more about the project.

xiaolinny avatar Dec 19 '25 06:12 xiaolinny