bitbox-wallet-app icon indicating copy to clipboard operation
bitbox-wallet-app copied to clipboard

frontend: revamp transaction history

Open thisconnect opened this issue 1 year ago • 10 comments

Redesigned transaction history in account overview to improve the list for mobile, better legibility and nicer look.

This revamp should also slightly improve performance, as it uses less DOM elements, moved SVG from JSX to img assets and does not use a Dialog for each transaction.

This PR includes some minor improvements (type fixes, removed unused assets etc.)

thisconnect avatar Sep 26 '24 09:09 thisconnect

Icons still needs to be updated.

thisconnect avatar Sep 26 '24 12:09 thisconnect

squashed some commits and rebased (after review part III).

thisconnect avatar Oct 08 '24 17:10 thisconnect

This is almost ready but there is a small issue with syncing blocks. I'll update the PR…

Screenshot 2024-10-14 at 09 01 29 Screenshot 2024-10-14 at 09 01 44 Screenshot 2024-10-14 at 09 02 15 Screenshot 2024-10-14 at 09 02 23

thisconnect avatar Oct 15 '24 07:10 thisconnect

also tested with "zoo zoo ... wrong" as there are a few failed ETH tx.

Screenshot 2024-10-16 at 15 53 39 Screenshot 2024-10-16 at 15 54 18

thisconnect avatar Oct 16 '24 14:10 thisconnect

fixed headersync (so it goes to the edge like before), added changelog entry and rebased

thisconnect avatar Oct 17 '24 10:10 thisconnect

rebased

thisconnect avatar Oct 21 '24 12:10 thisconnect

rebased

thisconnect avatar Oct 22 '24 16:10 thisconnect

Still reviewing & testing. For now looks good, but noticed that "Notes" label in the details.tsx (TransactionDetails) always broken into two lines (in all languages I tested: EN, DE, CZ).

fixed, but I couldn't figure out why it broke exactly.

thisconnect avatar Oct 22 '24 17:10 thisconnect

TX history looks good. But these look strange.. Something in this PR might've caused this regression?

Indeed, I messed up when rebasing in commit "frontend: refactor account component with view" I think this also caused the other bug you found.

fixedup and force pushed

thisconnect avatar Oct 23 '24 09:10 thisconnect

rebased without conflicts

thisconnect avatar Oct 23 '24 09:10 thisconnect