bitbox-wallet-app icon indicating copy to clipboard operation
bitbox-wallet-app copied to clipboard

experiment] frontend: show spinner after unlock, before accounts are loaded

Open benma opened this issue 1 year ago • 3 comments

After unlock, especially the first time, it can take many seconds for the initial set of accounts to be loaded. Until then, the app shows nothing in the sidebar and 'Please connect your device to get started'.

The user is easily confused, it seems as something went wrong.

We can probably speed up this loading with firmware and app changes, but this is a quick improvement that shows a spinner until the accounts become available.

benma avatar Feb 07 '24 15:02 benma

the fact that the loading screen disappears after loading the first accounts, but other accounts can still be discovered and added to the sidebar looks a bit buggy to me.

Generally I think it is better to show and render all data that is available, and if 1 account is already found, list it incrementally. I think it's better than having a loading screen for seconds/minutes and nothing happens.

@Beerosagos what if there was a small loading icon so that it is clear that it is still searching? (but also that would need some kind of discovery-is-finished event)

thisconnect avatar Feb 22 '24 09:02 thisconnect

@Beerosagos what if there was a small loading icon so that it is clear that it is still searching? (but also that would need some kind of discovery-is-finished event)

That would be really nice, imo

Beerosagos avatar Feb 22 '24 09:02 Beerosagos

Agree with @thisconnect, the loading screen should not stay until everything is discovered, that's way too long.

A spinner for accounts discovery makes sense, but that is really a separate issue. This PR/issue is that before anything is available, we need to show something instead of the "Please connect BitBox" screen, and there is no portfolio or accounts to go to in that time. So the full screen spinner during this time still makes sense right?

benma avatar Feb 22 '24 10:02 benma

Closing in favor of https://github.com/digitalbitbox/bitbox-wallet-app/pull/2683

benma avatar Apr 22 '24 15:04 benma