MikaLendingBot
MikaLendingBot copied to clipboard
Feature Request: Version checking & notification
Lots of changes are being made to this bot (Yay!) but subscribing to every issue is cluttering up my Inbox (Boo!). I'm not sure if I can subscribe to only "releases" or only to be notified when commits/merges on/to the master branch happen.
To that effect, I would like to see a daily/weekly version checker that simply prints a NOTE in the web gui and optionally, sends a notification using the new notifications additions that a new version is available.
Theoretically possible using a version file and a check between the local and remote versions.
I would like to have it automated, related to master commits.
On Tue, 2 May 2017, 23:56 Evan, [email protected] wrote:
Theoretically possible using a version file and a check between the local and remote versions.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Mikadily/poloniexlendingbot/issues/314#issuecomment-298773229, or mute the thread https://github.com/notifications/unsubscribe-auth/ABkc_hw-I6BAddvEtVB9zGrv5XNoitkkks5r16Z-gaJpZM4NNojE .
Should probably be done through Travis if you want it automated.
Version checking should be related to master commits. A thread/timer should check once a day/week/
We could check with a git command in the python script, if git is behind, however this will only work if the bot is running from a git folder and not a plain copy.
Ah yes, if someone downloads the .zip/.tgz, there won't be any git-related stuff. So I guess there would need to be a version.txt file with the current commit hash that checks against the master branch copy at github.com?
I've started some work on this. I'm adding a packaging branch where I'm hoping to address versioning, PyPi support and Travis builds with testing. Still a long way off, but it's being looked at.
We could move to a tag system and keep everything on the github side. Compare the local tags to the remote tags, and notify if a discrepancy is found.
Getting remote tags: https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-ls-remote.html
Just made a rudimentary solution, check it out #623