MikaLendingBot icon indicating copy to clipboard operation
MikaLendingBot copied to clipboard

Display Total Account Value

Open rnevet opened this issue 8 years ago • 5 comments

Display total account value (Lending, Margin, Exchange) in BTC and Output currency

Description

Implements issue https://github.com/Mikadily/poloniexlendingbot/issues/240 Closes #240

TESTING STAGE

In progress

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [X] I have read CONTRIBUTING.md
  • [X] I fully understand Github Flow.
  • [x] My code adheres to the code style of this project.
  • [ ] I have updated the documentation in /docs if I have changed the config, arguments, logic in how the bot works, or anything that understandably needs a documentation change.
  • [ ] I have updated the config file accordingly if my change requires a new configuration setting or changes an existing one.
  • [X] I have tested the bot with no issues for 24 continuous hours. If issues were experienced, they have been patched and tested again.

rnevet avatar Feb 28 '17 19:02 rnevet

TODO: Add configuration option to enable/disable the bot from adding this information to the output.

rnevet avatar Feb 28 '17 19:02 rnevet

Looks good so far, will test and review when you are done.

Evanito avatar Mar 07 '17 19:03 Evanito

Being over a year old.... is this still in progress or is it time to close it?

bkuhl avatar Apr 25 '18 00:04 bkuhl

@rnevet Missing Bitfinex support. Tough because Bitfinex does not return 'btcValue' like Polo does. Have to convert each coin using latest market data.

utdrmac avatar Jul 03 '18 15:07 utdrmac

Tried writing a quick patch for Bitfinex. Seems more trouble than it's worth. You'd have to add any/all coins back into all_currencies if you want the values calculated because Bitfinex does not return the estimated BTC value like polo does. So you have to first fetch all coin balances from each account type, fetch individual tickers for each coin (or use v2 API which allows requesting multiple), then calculate each coin's value. I had this somewhat working but my patch caused lending to stop so I gave up.

utdrmac avatar Jul 06 '18 16:07 utdrmac