SyliusElasticsearchPlugin icon indicating copy to clipboard operation
SyliusElasticsearchPlugin copied to clipboard

Published 20 hours ago • verified publisher icon BitBagCommerce

Support for PHP 8.0

Open lruozzi9 opened this issue 3 years ago • 2 comments

This plugin does not support PHP 8.0. https://github.com/BitBagCommerce/SyliusElasticsearchPlugin/blob/51a2b1edc280bfcfa6f206a98a38163a6500cd4a/composer.json#L8

lruozzi9 avatar Nov 29 '21 17:11 lruozzi9

In "bitbag/elasticsearch-plugin/src/QueryBuilder/ContainsNameQueryBuilder.php" I just replaced : "use Elastica\Query\Match;" by "use Elastica\Query\MatchQuery;" and "$nameQuery = new Match();" by "$nameQuery = new MatchQuery();"

and it works with PHP 8.0(.14 in my case) as Elastica\Query\Match only extends MatchQuery.

yanlep avatar Jan 04 '22 16:01 yanlep

Should be solved by https://github.com/BitBagCommerce/SyliusElasticsearchPlugin/pull/179

tavy315 avatar Jan 21 '22 22:01 tavy315

Hi @lruozzi9,

The PHP 8.0 is supported since v2.0.1: https://github.com/BitBagCommerce/SyliusElasticsearchPlugin/releases/tag/v2.0.1

senghe avatar Sep 20 '22 06:09 senghe