bitcoin-php icon indicating copy to clipboard operation
bitcoin-php copied to clipboard
verified publisher icon Bit-Wasp

SigHashInterface - API needs improvement

Open afk11 opened this issue 6 years ago • 0 comments

V1Hasher takes $amount in the constructor, effectively binding that object to that input.. This is at odds with SigHashInterface::calculate() taking $inputToSign as a parameter.

Maybe refactor? Also look into precomputing hashPrevOuts/hashSequences/hashOutputs?

afk11 avatar Oct 23 '19 00:10 afk11