bismuth
bismuth copied to clipboard
Bismuth-Forge
feat: smartgaps: Hide gaps if showing a single window
Summary
Adds a toggle that will hide gaps if only a single window is visible. The feature is disabled by default.
Implementation added to both the cpp and ts engines.
Breaking Changes
No
UI Changes
| Before | After |
|---|---|
 |
 |
Test Plan
- Make sure gaps are enabled, enable the smart gaps toggle, apply.
- Put a single window in the workspace, observe that there are no gaps.
- Open a second window, observe that there are gaps.
Related Issues
Closes #404
I had to bypass precommit hooks because clang-format is complaining about existing code.
Wait, but we already have a such feature:
What is the difference?
Yeah, the issue is actually closed https://github.com/Bismuth-Forge/bismuth/issues/404#issuecomment-1207200369
@defer So do you think maybe we can close this PR now as un-merged perhaps?
Also (BTW) when i enable this option: "Maximize sole window" it does seem to help or partially fix some other window bug? Whereby the tiling is partially broken / semi-works. Depending on certain windows / some of the virtual desktops / virtual screens. It's all a bit new to me still.
Anyhow if we can know to actual close this PR (that it does not add anything new / or better / worthwhile improvements needed). Then many thanks
