Hugo Gruson
Hugo Gruson
If I understand the request correctly, note that it is already part of `R CMD check`.
All tests are now passing. I'm not super happy about the complexity of this xpath but I can't think of something simpler at the moment. Please let me know if...
https://github.com/r-lib/lintr/issues/963 may be a good way to simplify the code eventually.
I was still a bit reluctant to merge this as https://github.com/datacarpentry/R-ecology-lesson/pull/919 shows that community members are still using these files. So I brought it up at the maintainers' meeting today...
> CONDUCT.Rmd should not be removed -- it should be renamed to CODE_OF_CONDUCT.md. Otherwise the link to the code of conduct at the bottom of the lesson is broken. I...
I have added a note in the README and will post on #919. How does this sound?
Would `all_equal_linter()` be an appropriate name for this new linter?
> The downstream workflows and the PR comments they create are important for quality control, especially for package updates, where they will show what package updates cause output to change....
> I'd also be very interested to understand how this last token could be removed. Here is a slightly more guided explanation in case that's useful. The most important change...
It's a bit blurry in my memory now and I would need to dive into it again if necessary, but I think I got it working in the example posted...