jellyfishsdk icon indicating copy to clipboard operation
jellyfishsdk copied to clipboard

feat(jellyfish-transaction): Add payback with collateral dftx

Open delphk opened this issue 3 years ago β€’ 4 comments

What this PR does / why we need it:

/kind feature

Which issue(s) does this PR fixes?:

Fixes #1769

Additional comments?:

delphk avatar Nov 03 '22 06:11 delphk

Code Climate has analyzed commit 675124d5 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

qlty-cloud-legacy[bot] avatar Nov 03 '22 06:11 qlty-cloud-legacy[bot]

Deploy Preview for jellyfishsdk ready!

Name Link
Latest commit 675124d5bb0336ec14fbabff5cf67b0176cde9fd
Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/63bf801664629e0009f9b896
Deploy Preview https://deploy-preview-1848--jellyfishsdk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Nov 03 '22 06:11 netlify[bot]

Codecov Report

Base: 90.74% // Head: 90.24% // Decreases project coverage by -0.49% :warning:

Coverage data is based on head (675124d) compared to base (3aeeb67). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   90.74%   90.24%   -0.50%     
==========================================
  Files         367      367              
  Lines       10771    10783      +12     
  Branches     1376     1377       +1     
==========================================
- Hits         9774     9731      -43     
- Misses        952      998      +46     
- Partials       45       54       +9     
Impacted Files Coverage Ξ”
...h-transaction-builder/src/txn/txn_builder_loans.ts 100.00% <100.00%> (+5.71%) :arrow_up:
...ages/jellyfish-transaction/src/script/dftx/dftx.ts 95.74% <100.00%> (+0.06%) :arrow_up:
...ellyfish-transaction/src/script/dftx/dftx_loans.ts 100.00% <100.00%> (ΓΈ)
...ckages/jellyfish-transaction/src/script/mapping.ts 94.26% <100.00%> (-1.22%) :arrow_down:
apps/whale-api/src/module.api/subsidy.ts 16.66% <0.00%> (-75.00%) :arrow_down:
apps/whale-api/src/module.api/stats.controller.ts 23.66% <0.00%> (-73.29%) :arrow_down:
packages/jellyfish-wallet/src/wallet_account.ts 33.33% <0.00%> (-62.97%) :arrow_down:
apps/ocean-api/src/modules/PlaygroundModule.ts 42.30% <0.00%> (-53.85%) :arrow_down:
packages/jellyfish-address/src/p2wsh.ts 48.27% <0.00%> (-51.73%) :arrow_down:
...ransaction-builder/src/txn/txn_builder_liq_pool.ts 50.00% <0.00%> (-50.00%) :arrow_down:
... and 72 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Nov 03 '22 07:11 codecov[bot]

Docker build preview for jellyfish/apps is ready!

Built with commit ed62d86bfbefe9c48499e157ebb36aef549355d1

  • ghcr.io/jellyfishsdk/legacy-api:pr-1848
  • ghcr.io/jellyfishsdk/ocean-api:pr-1848
  • ghcr.io/jellyfishsdk/playground-api:pr-1848
  • ghcr.io/jellyfishsdk/status-api:pr-1848
  • ghcr.io/jellyfishsdk/whale-api:pr-1848

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:ed62d86bfbefe9c48499e157ebb36aef549355d1
  • ghcr.io/jellyfishsdk/ocean-api:ed62d86bfbefe9c48499e157ebb36aef549355d1
  • ghcr.io/jellyfishsdk/playground-api:ed62d86bfbefe9c48499e157ebb36aef549355d1
  • ghcr.io/jellyfishsdk/status-api:ed62d86bfbefe9c48499e157ebb36aef549355d1
  • ghcr.io/jellyfishsdk/whale-api:ed62d86bfbefe9c48499e157ebb36aef549355d1

github-actions[bot] avatar Nov 03 '22 09:11 github-actions[bot]