jellyfishsdk icon indicating copy to clipboard operation
jellyfishsdk copied to clipboard

feat(jellyfish-api-core): add loan paybackWithCollateral RPC

Open delphk opened this issue 2 years ago β€’ 4 comments

What this PR does / why we need it:

/kind feature

Which issue(s) does this PR fixes?:

Fixes #1773

delphk avatar Oct 13 '22 09:10 delphk

Code Climate has analyzed commit f54539bb and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Oct 13 '22 09:10 codeclimate[bot]

Deploy Preview for jellyfishsdk ready!

Name Link
Latest commit f54539bbcc611b4efb04ae6ecb4ec5164fa5520a
Latest deploy log https://app.netlify.com/sites/jellyfishsdk/deploys/6349262baa9e560008deb6cb
Deploy Preview https://deploy-preview-1802--jellyfishsdk.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Oct 13 '22 09:10 netlify[bot]

Codecov Report

Base: 90.65% // Head: 92.86% // Increases project coverage by +2.21% :tada:

Coverage data is based on head (f54539b) compared to base (0874430). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1802      +/-   ##
==========================================
+ Coverage   90.65%   92.86%   +2.21%     
==========================================
  Files         361      361              
  Lines       10441    10443       +2     
  Branches     1307     1307              
==========================================
+ Hits         9465     9698     +233     
+ Misses        933      708     -225     
+ Partials       43       37       -6     
Impacted Files Coverage Ξ”
packages/jellyfish-api-core/src/category/loan.ts 100.00% <100.00%> (ΓΈ)
packages/whale-api-client/src/api/rawtx.ts 25.00% <0.00%> (-75.00%) :arrow_down:
...hale-api/src/module.api/legacy.subgraph.service.ts 16.12% <0.00%> (-69.36%) :arrow_down:
apps/libs/caches/src/LegacyCache.ts 33.33% <0.00%> (-66.67%) :arrow_down:
apps/whale-api/src/module.api/legacy.controller.ts 36.84% <0.00%> (-63.16%) :arrow_down:
...-api-client/src/errors/client.timeout.exception.ts 50.00% <0.00%> (-50.00%) :arrow_down:
...es/jellyfish-api-core/src/category/icxorderbook.ts 95.23% <0.00%> (-4.77%) :arrow_down:
packages/jellyfish-api-core/src/category/wallet.ts 97.70% <0.00%> (-2.30%) :arrow_down:
...pps/whale-api/src/module.api/loan.vault.service.ts 90.17% <0.00%> (+0.89%) :arrow_up:
...kages/jellyfish-wallet-encrypted/src/encryption.ts 93.84% <0.00%> (+1.53%) :arrow_up:
... and 43 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 13 '22 09:10 codecov[bot]

Docker build preview for jellyfish/apps is ready!

Built with commit 27ef8327efcd19604ad38bd8d44687624f9a30b9

  • ghcr.io/jellyfishsdk/legacy-api:pr-1802
  • ghcr.io/jellyfishsdk/ocean-api:pr-1802
  • ghcr.io/jellyfishsdk/playground-api:pr-1802
  • ghcr.io/jellyfishsdk/status-api:pr-1802
  • ghcr.io/jellyfishsdk/whale-api:pr-1802

You can also get an immutable image with the commit hash

  • ghcr.io/jellyfishsdk/legacy-api:27ef8327efcd19604ad38bd8d44687624f9a30b9
  • ghcr.io/jellyfishsdk/ocean-api:27ef8327efcd19604ad38bd8d44687624f9a30b9
  • ghcr.io/jellyfishsdk/playground-api:27ef8327efcd19604ad38bd8d44687624f9a30b9
  • ghcr.io/jellyfishsdk/status-api:27ef8327efcd19604ad38bd8d44687624f9a30b9
  • ghcr.io/jellyfishsdk/whale-api:27ef8327efcd19604ad38bd8d44687624f9a30b9

github-actions[bot] avatar Oct 13 '22 09:10 github-actions[bot]