jellyfishsdk icon indicating copy to clipboard operation
jellyfishsdk copied to clipboard

`WhaleApiResponse` should include a "meta" field that include defid node stats.

Open fuxingloh opened this issue 2 years ago • 1 comments

What would you like to be added:

https://github.com/JellyfishSDK/jellyfish/blob/7e88ff530a4f97216086c6e09ec23654c7778033/packages/whale-api-client/src/whale.api.response.ts#L4-L8

Should include:

{
  "data":{},
  "meta": {
    "blockchain": {
      "hash": "923fe2d3f5920163d2401095de5647ce25ee3463863fad04e76eec48719fb8a3",
      "height": 1398516,
      "medianTime": 1637921787,
      "time": 1637921973
    }
  }
}

Why is this needed:

Including blockchain information to WhaleApiResponse will make it easier for the client to determine the ApiResponse is reliable and up to date before they perform their subsequent actions.

/triage accepted /area packages apps /apps whale-api

fuxingloh avatar Jul 25 '22 10:07 fuxingloh

/priority important-soon

fuxingloh avatar Oct 07 '22 06:10 fuxingloh