defiscan.live icon indicating copy to clipboard operation
defiscan.live copied to clipboard

Proper fixes for `/dex` page

Open joeldavidw opened this issue 2 years ago • 4 comments

What would you like to be added:

Quick fixes were made in https://github.com/DeFiCh/scan/pull/1316 & #1318.

Proper Fix for the following are needed:

  • Filter for splitted pairs (e.g. amzn-dusd/v1)
  • Usage of poolpairs displaySymbol instead of tokenA.displaySymbol for pairs where tokenA is used across multiple pairs (dUSDT-DUSD and dUSDT_DFI).

Why is this needed:

joeldavidw avatar Jul 19 '22 15:07 joeldavidw

@joeldavidw: Thanks for opening an issue, it is currently awaiting triage.

The triage/accepted label can be added by foundation members by writing /triage accepted in a comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Jul 19 '22 15:07 github-actions[bot]

@joeldavidw: There are no 'area' labels on this issue. Adding an appropriate label will greatly expedite the process for us. You can add as many area as you see fit. If you are unsure what to do you can ignore this!

You can add area labels by leaving a /area comment.

Details

I am a bot created to help the DeFiCh developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

github-actions[bot] avatar Jul 19 '22 15:07 github-actions[bot]

May want to consider using full poolpair displaySymbol from now on. To prevent links from breaking in the future.

cc: @gjj

joeldavidw avatar Jul 19 '22 15:07 joeldavidw

You mean like the /v1 in:

  • https://defiscan.live/tokens/dGOOGL/v1
  • https://defiscan.live/tokens/dGOOGL-dDUSD/v1
  • https://defiscan.live/tokens/dAMZN/v1
  • ...and all other v1 stock split symbols?

gjj avatar Jul 20 '22 03:07 gjj