defichain-wallet
defichain-wallet copied to clipboard
feature(ui-ux): add sorting feature to loans tokens screen
What this PR does / why we need it:
Added a new sorting feature to the loans tokens screen
- [x] Add sorting function
- [x] Update e2e
- [x] Update translation
- [x] Code check, refactor and cleanup
Which issue(s) does this PR fixes?:
Fixes #
Additional comments?:
Developer Checklist:
- [x] Read your code changes at least once
- [x] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
- [x] No console errors on web
- [x] Tested on Light mode and Dark mode*
- [x] Your UI implementation visually matched the rendered design*
- [ ] Unit tests*
- [x] Added e2e tests*
- [x] Added translations*
Code Climate has analyzed commit 7fc1845c and detected 2 issues on this pull request.
Here's the issue category breakdown:
Category | Count |
---|---|
Duplication | 2 |
View more on Code Climate.
Missing Translations Report
The following translations are missing for this pull request.
{
"missingLanguageItems": {
"zh-Hans": {
"missingCount": 0,
"labels": {},
"totalCount": 1906,
"allLabels": "{}"
},
"zh-Hant": {
"missingCount": 0,
"labels": {},
"totalCount": 1906,
"allLabels": "{}"
},
"fr": {
"missingCount": 0,
"labels": {},
"totalCount": 1906,
"allLabels": "{}"
},
"es": {
"missingCount": 0,
"labels": {},
"totalCount": 1906,
"allLabels": "{}"
},
"it": {
"missingCount": 0,
"labels": {},
"totalCount": 1906,
"allLabels": "{}"
}
},
"totalMissingCount": 0
}
Codecov Report
Base: 42.00% // Head: 20.12% // Decreases project coverage by -21.88%
:warning:
Coverage data is based on head (
7fc1845
) compared to base (c1ded03
). Patch coverage: 1.23% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #3626 +/- ##
===========================================
- Coverage 42.00% 20.12% -21.89%
===========================================
Files 493 483 -10
Lines 12966 12859 -107
Branches 4195 4189 -6
===========================================
- Hits 5447 2588 -2859
- Misses 7462 10227 +2765
+ Partials 57 44 -13
Impacted Files | Coverage Δ | |
---|---|---|
mobile-app/app/components/BottomSheetWithNavV2.tsx | 16.66% <ø> (-33.34%) |
:arrow_down: |
...screens/AppNavigator/screens/Loans/LoansScreen.tsx | 0.00% <0.00%> (-95.84%) |
:arrow_down: |
...ppNavigator/screens/Loans/components/LoanCards.tsx | 0.60% <0.00%> (-67.20%) |
:arrow_down: |
...or/screens/Loans/components/LoansTokensSortRow.tsx | 5.26% <5.26%> (ø) |
|
shared/store/index.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
mobile-app/app/constants/Theme.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
shared/contexts/StatsProvider.tsx | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
mobile-app/app/hooks/useDebounce.ts | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
mobile-app/app/screens/Main.web.tsx | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
shared/contexts/WalletDataProvider.tsx | 0.00% <0.00%> (-100.00%) |
:arrow_down: |
... and 160 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Build preview for DeFiChain Wallet is ready!
Built with commit 7b3c155df9b1205760b38f01f0e0c17edf16aa4d
https://expo.io/@defichain/wallet?release-channel=pr-preview-3626
Test summary
Run details
Project | wallet |
Status | Failed |
Commit | 7b3c155df9 ℹ️ |
Started | Oct 25, 2022 5:53 AM |
Ended | Oct 25, 2022 6:26 AM |
Duration | 33:37 💡 |
OS | Linux Ubuntu - 20.04 |
Browser | Chrome 106 ![]() |
View run in Cypress Dashboard ➡️
Failures
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard