defichain-wallet icon indicating copy to clipboard operation
defichain-wallet copied to clipboard

chore(e2e): fixed failing e2e

Open fullstackninja864 opened this issue 2 years ago • 5 comments

What this PR does / why we need it:

Which issue(s) does this PR fixes?:

Fixes #

Additional comments?:

Developer Checklist:

  • [ ] Read your code changes at least once
  • [ ] Tested on iOS/Android device (e.g, No crashes, library supported etc.)
  • [ ] No console errors on web
  • [ ] Tested on Light mode and Dark mode*
  • [ ] Your UI implementation visually matched the rendered design*
  • [ ] Unit tests*
  • [ ] Added e2e tests*
  • [ ] Added translations*

fullstackninja864 avatar Oct 06 '22 04:10 fullstackninja864

Code Climate has analyzed commit 2a4094ed and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Oct 06 '22 04:10 codeclimate[bot]

Missing Translations Report

The following translations are missing for this pull request.

{
    "missingLanguageItems": {
        "zh-Hans": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1759,
            "allLabels": "{}"
        },
        "zh-Hant": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1759,
            "allLabels": "{}"
        },
        "fr": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1759,
            "allLabels": "{}"
        },
        "es": {
            "missingCount": 2,
            "labels": {
                "screens/LoansScreen": [
                    "Loan tokens get their prices from oracles."
                ],
                "screens/EditLoanSchemeScreen": [
                    "Continue"
                ]
            },
            "totalCount": 1759,
            "allLabels": "{\n    \"screens/LoansScreen\": [\n        \"Loan tokens get their prices from oracles.\"\n    ],\n    \"screens/EditLoanSchemeScreen\": [\n        \"Continue\"\n    ]\n}"
        },
        "it": {
            "missingCount": 0,
            "labels": {},
            "totalCount": 1759,
            "allLabels": "{}"
        }
    },
    "totalMissingCount": 2
}

defichain-bot avatar Oct 06 '22 04:10 defichain-bot

Codecov Report

Base: 20.32% // Head: 20.32% // No change to project coverage :thumbsup:

Coverage data is based on head (2a4094e) compared to base (4f9d5ab). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3622   +/-   ##
=======================================
  Coverage   20.32%   20.32%           
=======================================
  Files         473      473           
  Lines       12692    12692           
  Branches     4088     4088           
=======================================
  Hits         2580     2580           
  Misses      10067    10067           
  Partials       45       45           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Oct 06 '22 04:10 codecov[bot]

Build preview for DeFiChain Wallet is ready!

Built with commit 84e6bbf0ae5348147d052fa7d2006531feb9f6f6

https://expo.io/@defichain/wallet?release-channel=pr-preview-3622

defichain-bot avatar Oct 06 '22 04:10 defichain-bot



Test summary

469 46 1 45


Run details

Project wallet
Status Failed
Commit 49dc9ac1c1 ℹ️
Started Oct 6, 2022 6:50 AM
Ended Oct 6, 2022 7:20 AM
Duration 30:00 💡
OS Linux Ubuntu - 20.04
Browser Chrome 106

View run in Cypress Dashboard ➡️


Failures

loans/collateral.spec.ts Failed
1 Wallet - Loans - 50% valid collateral token ratio > should display warning message while taking loan
2 Wallet - Loans - 50% valid collateral token ratio > should display warning message while removing collateral
dex/swap/swap_future_withdraw.spec.ts Failed
1 Wallet - Future Swap -> Display -> Withdraw flow > should future swap DUSD -> dTU10
2 Wallet - Future Swap -> Display -> Withdraw flow > should display correct withdraw transaction details
3 Wallet - Future Swap -> Display -> Withdraw flow > should display correct confirmation withdraw transaction details
4 Wallet - Future Swap -> Display -> Withdraw flow > should display partial withdrawal amount
dex/swap/swap_instant_non_dfi.spec.ts Failed
1 Wallet - DEX - Instant Swap (non-DFI) > should be able to use/validate custom slippage tolerance
dex/add_liquidity.spec.ts Failed
1 Wallet - DEX - Add Liquidity > should update both token and build summary when click on max amount button
2 Wallet - DEX - Combine Add and Confirm Liquidity Spec > should get disabled submit button when value is zero
3 Wallet - DEX - Add Liquidity Confirm Txn > should have updated confirm info
This comment includes only the first 10 test failures. See all 46 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Oct 06 '22 07:10 cypress[bot]

@fullstackninja864 can we update this?

thedoublejay avatar Nov 03 '22 06:11 thedoublejay

not relevant after v2 changes

kyleleow avatar Nov 03 '22 09:11 kyleleow